Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Side by Side Diff: Source/core/inspector/InspectorPageAgent.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/DOMEditor.cpp ('k') | Source/core/inspector/InspectorStyleSheet.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1014 matching lines...) Expand 10 before | Expand all | Expand 10 after
1025 { 1025 {
1026 RefPtr<TypeBuilder::Page::Frame> frameObject = TypeBuilder::Page::Frame::cre ate() 1026 RefPtr<TypeBuilder::Page::Frame> frameObject = TypeBuilder::Page::Frame::cre ate()
1027 .setId(frameId(frame)) 1027 .setId(frameId(frame))
1028 .setLoaderId(loaderId(frame->loader().documentLoader())) 1028 .setLoaderId(loaderId(frame->loader().documentLoader()))
1029 .setUrl(urlWithoutFragment(frame->document()->url()).string()) 1029 .setUrl(urlWithoutFragment(frame->document()->url()).string())
1030 .setMimeType(frame->loader().documentLoader()->responseMIMEType()) 1030 .setMimeType(frame->loader().documentLoader()->responseMIMEType())
1031 .setSecurityOrigin(frame->document()->securityOrigin()->toRawString()); 1031 .setSecurityOrigin(frame->document()->securityOrigin()->toRawString());
1032 if (frame->tree().parent()) 1032 if (frame->tree().parent())
1033 frameObject->setParentId(frameId(frame->tree().parent())); 1033 frameObject->setParentId(frameId(frame->tree().parent()));
1034 if (frame->ownerElement()) { 1034 if (frame->ownerElement()) {
1035 String name = frame->ownerElement()->getNameAttribute(); 1035 AtomicString name = frame->ownerElement()->getNameAttribute();
1036 if (name.isEmpty()) 1036 if (name.isEmpty())
1037 name = frame->ownerElement()->getAttribute(HTMLNames::idAttr); 1037 name = frame->ownerElement()->getAttribute(HTMLNames::idAttr);
1038 frameObject->setName(name); 1038 frameObject->setName(name);
1039 } 1039 }
1040 1040
1041 return frameObject; 1041 return frameObject;
1042 } 1042 }
1043 1043
1044 PassRefPtr<TypeBuilder::Page::FrameResourceTree> InspectorPageAgent::buildObject ForFrameTree(Frame* frame) 1044 PassRefPtr<TypeBuilder::Page::FrameResourceTree> InspectorPageAgent::buildObject ForFrameTree(Frame* frame)
1045 { 1045 {
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
1249 } 1249 }
1250 1250
1251 void InspectorPageAgent::setShowViewportSizeOnResize(ErrorString*, bool show, co nst bool* showGrid) 1251 void InspectorPageAgent::setShowViewportSizeOnResize(ErrorString*, bool show, co nst bool* showGrid)
1252 { 1252 {
1253 m_state->setBoolean(PageAgentState::showSizeOnResize, show); 1253 m_state->setBoolean(PageAgentState::showSizeOnResize, show);
1254 m_state->setBoolean(PageAgentState::showGridOnResize, showGrid && *showGrid) ; 1254 m_state->setBoolean(PageAgentState::showGridOnResize, showGrid && *showGrid) ;
1255 } 1255 }
1256 1256
1257 } // namespace WebCore 1257 } // namespace WebCore
1258 1258
OLDNEW
« no previous file with comments | « Source/core/inspector/DOMEditor.cpp ('k') | Source/core/inspector/InspectorStyleSheet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698