Make sure getAttribute() / setAttribute() callers use AtomicStrings

Source/core/inspector/DOMEditor.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 112 matching lines @@
 private:
     RefPtr<Node> m_parentNode;
     RefPtr<Node> m_node;
     RefPtr<Node> m_anchorNode;
     OwnPtr<RemoveChildAction> m_removeChildAction;
 };
 
 class DOMEditor::RemoveAttributeAction : public InspectorHistory::Action {
     WTF_MAKE_NONCOPYABLE(RemoveAttributeAction);
 public:
-    RemoveAttributeAction(Element* element, const String& name)
+    RemoveAttributeAction(Element* element, const AtomicString& name)
         : InspectorHistory::Action("RemoveAttribute")
         , m_element(element)
         , m_name(name)
     {
     }
 
     virtual bool perform(ExceptionState& exceptionState)
     {
         m_value = m_element->getAttribute(m_name);
         return redo(exceptionState);
     }
 
     virtual bool undo(ExceptionState& exceptionState)
     {
         m_element->setAttribute(m_name, m_value, exceptionState);
         return true;
     }
 
     virtual bool redo(ExceptionState&)
     {
         m_element->removeAttribute(m_name);
         return true;
     }
 
 private:
     RefPtr<Element> m_element;
-    String m_name;
-    String m_value;
+    AtomicString m_name;
+    AtomicString m_value;
 };
 
 class DOMEditor::SetAttributeAction : public InspectorHistory::Action {
     WTF_MAKE_NONCOPYABLE(SetAttributeAction);
 public:
-    SetAttributeAction(Element* element, const String& name, const String& value)
+    SetAttributeAction(Element* element, const AtomicString& name, const AtomicString& value)
         : InspectorHistory::Action("SetAttribute")
         , m_element(element)
         , m_name(name)
         , m_value(value)
         , m_hadAttribute(false)
     {
     }
 
     virtual bool perform(ExceptionState& exceptionState)
     {
@@ skipping 13 matching lines @@
     }
 
     virtual bool redo(ExceptionState& exceptionState)
     {
         m_element->setAttribute(m_name, m_value, exceptionState);
         return true;
     }
 
 private:
     RefPtr<Element> m_element;
-    String m_name;
-    String m_value;
+    AtomicString m_name;
+    AtomicString m_value;
     bool m_hadAttribute;
-    String m_oldValue;
+    AtomicString m_oldValue;
 };
 
 class DOMEditor::SetOuterHTMLAction : public InspectorHistory::Action {
     WTF_MAKE_NONCOPYABLE(SetOuterHTMLAction);
 public:
     SetOuterHTMLAction(Node* node, const String& html)
         : InspectorHistory::Action("SetOuterHTML")
         , m_node(node)
         , m_nextSibling(node->nextSibling())
         , m_html(html)
@@ skipping 237 matching lines @@
 bool DOMEditor::replaceWholeText(Text* textNode, const String& text, ErrorString* errorString)
 {
     TrackExceptionState exceptionState;
     bool result = replaceWholeText(textNode, text, exceptionState);
     populateErrorString(exceptionState, errorString);
     return result;
 }
 
 } // namespace WebCore