Source/core/html/HTMLButtonElement.cpp - Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLButtonElement.cpp

Issue 99333011: Make sure getAttribute() / setAttribute() callers use AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.

6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)	6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)

7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)	7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)

8 *	8 *

9 * This library is free software; you can redistribute it and/or	9 * This library is free software; you can redistribute it and/or

10 * modify it under the terms of the GNU Library General Public	10 * modify it under the terms of the GNU Library General Public

(...skipping 176 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
187 focus();	187 focus();

188	188

189 dispatchSimulatedClick(0, sendMouseEvents ? SendMouseUpDownEvents : SendNoEv ents);	189 dispatchSimulatedClick(0, sendMouseEvents ? SendMouseUpDownEvents : SendNoEv ents);

190 }	190 }

191	191

192 bool HTMLButtonElement::isURLAttribute(const Attribute& attribute) const	192 bool HTMLButtonElement::isURLAttribute(const Attribute& attribute) const

193 {	193 {

194 return attribute.name() == formactionAttr \|\| HTMLFormControlElement::isURLAt tribute(attribute);	194 return attribute.name() == formactionAttr \|\| HTMLFormControlElement::isURLAt tribute(attribute);

195 }	195 }

196	196

197 String HTMLButtonElement::value() const	197 const AtomicString& HTMLButtonElement::value() const

198 {	198 {

199 return getAttribute(valueAttr);	199 return getAttribute(valueAttr);

200 }	200 }

201	201

202 bool HTMLButtonElement::recalcWillValidate() const	202 bool HTMLButtonElement::recalcWillValidate() const

203 {	203 {

204 return m_type == SUBMIT && HTMLFormControlElement::recalcWillValidate();	204 return m_type == SUBMIT && HTMLFormControlElement::recalcWillValidate();

205 }	205 }

206	206

207 bool HTMLButtonElement::isInteractiveContent() const	207 bool HTMLButtonElement::isInteractiveContent() const

208 {	208 {

209 return true;	209 return true;

210 }	210 }

211	211

212 } // namespace	212 } // namespace

OLD	NEW

« no previous file with comments | « Source/core/html/HTMLButtonElement.h ('k') | Source/core/html/HTMLDetailsElement.cpp » ('j') | no next file with comments »