Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: Source/core/loader/DocumentWriter.h

Issue 99333006: Use AtomicString type more consistently for mimeType / encoding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | Source/core/loader/DocumentWriter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/DocumentWriter.h
diff --git a/Source/core/loader/DocumentWriter.h b/Source/core/loader/DocumentWriter.h
index 0f7eb5b1a1aa5d13e2213f7116c598b6de131d8f..4e79045a1e909594daba1502b26a84ff9a21bc72 100644
--- a/Source/core/loader/DocumentWriter.h
+++ b/Source/core/loader/DocumentWriter.h
@@ -45,7 +45,7 @@ class TextResourceDecoder;
class DocumentWriter : public RefCounted<DocumentWriter> {
WTF_MAKE_NONCOPYABLE(DocumentWriter);
public:
- static PassRefPtr<DocumentWriter> create(Document*, const String& mimeType = "", const String& encoding = "", bool encodingUserChoosen = false);
+ static PassRefPtr<DocumentWriter> create(Document*, const AtomicString& mimeType = emptyAtom, const AtomicString& encoding = emptyAtom, bool encodingUserChoosen = false);
~DocumentWriter();
@@ -57,8 +57,8 @@ public:
void addData(const char* bytes, size_t length);
- const String& mimeType() const { return m_decoderBuilder.mimeType(); }
- const String& encoding() const { return m_decoderBuilder.encoding(); }
+ const AtomicString& mimeType() const { return m_decoderBuilder.mimeType(); }
+ const AtomicString& encoding() const { return m_decoderBuilder.encoding(); }
bool encodingWasChosenByUser() const { return m_decoderBuilder.encodingWasChosenByUser(); }
// Exposed for DocumentLoader::replaceDocument.
@@ -69,7 +69,7 @@ public:
void setDocumentWasLoadedAsPartOfNavigation();
private:
- DocumentWriter(Document*, const String& mimeType, const String& encoding, bool encodingUserChoosen);
+ DocumentWriter(Document*, const AtomicString& mimeType, const AtomicString& encoding, bool encodingUserChoosen);
PassRefPtr<Document> createDocument(const KURL&);
« no previous file with comments | « Source/core/loader/DocumentLoader.cpp ('k') | Source/core/loader/DocumentWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698