Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/loader/TextResourceDecoderBuilder.h

Issue 99333006: Use AtomicString type more consistently for mimeType / encoding (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/loader/SubstituteData.h ('k') | Source/core/loader/TextResourceDecoderBuilder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 24 matching lines...) Expand all
35 #include "wtf/PassRefPtr.h" 35 #include "wtf/PassRefPtr.h"
36 #include "wtf/text/WTFString.h" 36 #include "wtf/text/WTFString.h"
37 37
38 namespace WebCore { 38 namespace WebCore {
39 39
40 class Document; 40 class Document;
41 class TextResourceDecoder; 41 class TextResourceDecoder;
42 42
43 class TextResourceDecoderBuilder { 43 class TextResourceDecoderBuilder {
44 public: 44 public:
45 TextResourceDecoderBuilder(const String& mimeType, const String& encoding, b ool encodingUserChoosen); 45 TextResourceDecoderBuilder(const AtomicString& mimeType, const AtomicString& encoding, bool encodingUserChoosen);
46 ~TextResourceDecoderBuilder(); 46 ~TextResourceDecoderBuilder();
47 47
48 PassOwnPtr<TextResourceDecoder> buildFor(Document*); 48 PassOwnPtr<TextResourceDecoder> buildFor(Document*);
49 49
50 const String& mimeType() const { return m_mimeType; } 50 const AtomicString& mimeType() const { return m_mimeType; }
51 const String& encoding() const { return m_encoding; } 51 const AtomicString& encoding() const { return m_encoding; }
52 bool encodingWasChosenByUser() const { return m_encodingWasChosenByUser; } 52 bool encodingWasChosenByUser() const { return m_encodingWasChosenByUser; }
53 53
54 void clear(); 54 void clear();
55 55
56 private: 56 private:
57 PassOwnPtr<TextResourceDecoder> createDecoderInstance(Document*); 57 PassOwnPtr<TextResourceDecoder> createDecoderInstance(Document*);
58 void setupEncoding(TextResourceDecoder*, Document*); 58 void setupEncoding(TextResourceDecoder*, Document*);
59 59
60 String m_mimeType; 60 AtomicString m_mimeType;
61 String m_encoding; 61 AtomicString m_encoding;
62 bool m_encodingWasChosenByUser; 62 bool m_encodingWasChosenByUser;
63 }; 63 };
64 64
65 } // namespace WebCore 65 } // namespace WebCore
66 66
67 #endif // TextResourceDecoderBuilder_h 67 #endif // TextResourceDecoderBuilder_h
OLDNEW
« no previous file with comments | « Source/core/loader/SubstituteData.h ('k') | Source/core/loader/TextResourceDecoderBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698