chromeos/dbus/bluetooth_media_transport_client.cc - Issue 993273002: device/bluetooth: Add I/O watcher for audio data retrieval triggered by state change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/bluetooth_media_transport_client.cc

Issue 993273002: device/bluetooth: Add I/O watcher for audio data retrieval triggered by state change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved some overrides of BluetoothAudioSinkChromeOS to its private section and fixed nits. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/dbus/bluetooth_media_transport_client.h ('k') | chromeos/dbus/fake_bluetooth_media_transport_client.h » ('j') | chromeos/dbus/fake_bluetooth_media_transport_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/dbus/bluetooth_media_transport_client.cc

diff --git a/chromeos/dbus/bluetooth_media_transport_client.cc b/chromeos/dbus/bluetooth_media_transport_client.cc

index 2be8a5639efa46f7f140eb62af71d1f91a0db2ad..9851cbcb8f1b501a3778afec4b875ffd6cc73ce0 100644

--- a/chromeos/dbus/bluetooth_media_transport_client.cc

+++ b/chromeos/dbus/bluetooth_media_transport_client.cc

@@ -241,7 +241,16 @@ class BluetoothMediaTransportClientImpl

if (reader.PopFileDescriptor(&fd) &&

reader.PopUint16(&read_mtu) &&

reader.PopUint16(&write_mtu)) {

- callback.Run(fd, read_mtu, write_mtu);

+ fd.CheckValidity();

+ DCHECK(fd.is_valid());

+ VLOG(1) << "OnAcquireSuccess - fd: "<< fd.value()

+ <<", read MTU: " << read_mtu

+ <<", write MTU: " << write_mtu;

+ // The ownership of the file descriptor is transferred to the user

+ // application.

+ callback.Run(&fd, read_mtu, write_mtu);

return;

}