mojo/gpu/BUILD.gn - Issue 993253003: Modify build_gles2_cmd_buffer.py to generate a class that implements gpu::GLES2Interace and for eac…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: mojo/gpu/BUILD.gn

Issue 993253003: Modify build_gles2_cmd_buffer.py to generate a class that implements gpu::GLES2Interace and for eac… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
	jamesr 2015/03/23 18:03:14 no (c) no (c) alhaad 2015/03/23 18:15:54 Done. Show quoted text On 2015/03/23 18:03:14, jamesr wrote: > no (c) Done.
	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 component("mojo_gles2_implementation") {
	jamesr 2015/03/23 18:03:14 no need for this to be a component, is there? just no need for this to be a component, is there? just make this a source_set alhaad 2015/03/23 18:15:55 Done. Show quoted text On 2015/03/23 18:03:14, jamesr wrote: > no need for this to be a component, is there? just make this a source_set Done.
	6 sources = [

	7 "mojo_gles2_impl_autogen.cc",

	8 "mojo_gles2_impl_autogen.h",

	9 ]

	10

	11 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

	12

	13 defines = [ "GLES2_IMPL_IMPLEMENTATION" ]
	jamesr 2015/03/23 18:03:14 and remove this. you don't have an export header s and remove this. you don't have an export header so having a _IMPLEMENTATION define is unnecessary (and will cause problems on windows if you #include headers from a component that uses GLES2_IMPL_...) alhaad 2015/03/23 18:15:54 Done. Show quoted text On 2015/03/23 18:03:14, jamesr wrote: > and remove this. you don't have an export header so having a _IMPLEMENTATION > define is unnecessary (and will cause problems on windows if you #include > headers from a component that uses GLES2_IMPL_...) Done.
	14

	15 deps = [

	16 "//gpu/command_buffer/client:gles2_interface",

	17 "//third_party/mojo/src/mojo/public/c/gles2",

	18 ]

	19 }

OLD	NEW

« mojo/cc/context_provider_mojo.h ('K') | « mojo/cc/context_provider_mojo.cc ('k') | mojo/gpu/DEPS » ('j') | no next file with comments »