MacViews: Implement Window-modal dialogs using sheets

MacViews: Implement Window-modal dialogs using sheets

These are used, e.g., for the Bookmark -> Edit... dialogs on Cocoa and
Views.

This gets WidgetTestInteractive.*Window*ModalWindowDestroyedActivationTest
passing.

WidgetTestInteractive.*System*ModalWindowReleasesCapture is disabled in
this CL. System modal windows are not needed on Mac.

Currently the implementation on MacViews assumes all modal dialogs are
shown using a sheet. On Cocoa, this is not always true for
WebContents-Modal dialogs (e.g. cookies and site data), but it is true
for some WebContents-Modal dialogs (e.g. certificate information).

A follow-up will add logic to ensure WebContents-Modal dialogs are
handled appropriately, and have good test coverage.

After this all tests pass on the current mac trybot configuration with
toolkit_views=1.

BUG=403679
Committed: https://crrev.com/3de6ad4c2b4c8f52daa2119a24063cd9309460e6
Cr-Commit-Position: refs/heads/master@{#320977}

[tapted, 2015-03-11 22:33:40]

Patchset #7 (id:120001) has been deleted

[tapted, 2015-03-11 22:40:45]

Patchset #5 (id:80001) has been deleted

[tapted, 2015-03-11 23:04:22]

Patchset #2 (id:20001) has been deleted

[tapted, 2015-03-11 23:12:44]

tapted@chromium.org changed reviewers:
+ andresantoso@chromium.org

[tapted, 2015-03-11 23:15:15]

Hi Andre WDYT of this approach? Note this is based off the
WidgetFocusChangeListener change in http://crrev.com/994333003

[Andre, 2015-03-12 00:33:08]

LGTM

[tapted, 2015-03-17 06:31:26]

Patchset #7 (id:180001) has been deleted

[tapted, 2015-03-17 10:06:12]

Patchset #7 (id:200001) has been deleted

[tapted, 2015-03-17 10:06:24]

Patchset #6 (id:160001) has been deleted

[tapted, 2015-03-17 10:39:48]

tapted@chromium.org changed reviewers:
+ sky@chromium.org

[tapted, 2015-03-17 10:39:48]

Hi sky, please take a look for owners (widget_interactive_uitest.cc,
views/examples/*, chrome/test/BUILD.gn and interactive_ui_tests.isolate )

Andre - note, a small change in patchset 6 vs patchset 5 to gyp/gn for a missing
dependency that this test case tickled (build flake when running on bots)

Thanks!

https://codereview.chromium.org/993253002/diff/220001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/993253002/diff/220001/chrome/chrome_tests.gyp...
chrome/chrome_tests.gypi:1469: '../ui/resources/ui_resources.gyp:ui_test_pak',
this was a missing dependency for the resource file loading noted below, which
got picked up on a mac bot (but is likely a buildflake on non-mac as well). The
combination of flipping toolkit-views + analyze was able to pick it up, and it
was easy to confirm/verify with `rm  out/Debug/ui_test.pak`

https://codereview.chromium.org/993253002/diff/220001/chrome/interactive_ui_t...
File chrome/interactive_ui_tests.isolate (right):

https://codereview.chromium.org/993253002/diff/220001/chrome/interactive_ui_t...
chrome/interactive_ui_tests.isolate:58: '<(PRODUCT_DIR)/ui_test.pak',
There wasn't a precedent for a "toolkit_views" condition here (so the gypi
change is also not in toolkit_views).

https://codereview.chromium.org/993253002/diff/220001/ui/views/widget/widget_...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/993253002/diff/220001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:237:
ui::ResourceBundle::InitSharedInstanceWithPakPath(ui_test_pak_path);
(note)

[sky, 2015-03-17 19:04:39]

LGTM

[tapted, 2015-03-17 20:29:01]

The CQ bit was checked by tapted@chromium.org

[tapted, 2015-03-17 20:29:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
andresantoso@chromium.org
Link to the patchset: https://codereview.chromium.org/993253002/#ps220001
(title: "update isolate")

[commit-bot: I haz the power, 2015-03-17 20:30:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993253002/220001

[commit-bot: I haz the power, 2015-03-17 21:28:36]

Committed patchset #6 (id:220001)

[commit-bot: I haz the power, 2015-03-17 21:29:11]

Patchset 6 (id:??) landed as
https://crrev.com/3de6ad4c2b4c8f52daa2119a24063cd9309460e6
Cr-Commit-Position: refs/heads/master@{#320977}