Issue 99323005: [Mojo] Fix race condition in sample_app's SwapBuffers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99323005: [Mojo] Fix race condition in sample_app's SwapBuffers (Closed)

Created:
7 years ago by abarth-chromium

Modified:
7 years ago

Reviewers:
DaveMoore

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Mojo] Fix race condition in sample_app's SwapBuffers The in-process command buffer expects all of its callers to be on a single thread. Prior to this CL, we were bouncing back to the shell thread to call swap buffers. Now we call SwapBuffers from sample_app's thread. R=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238223

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -21 lines)			Patch
M	mojo/examples/sample_app/native_viewport_client_impl.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/examples/sample_app/sample_gles2_delegate.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	mojo/examples/sample_app/sample_gles2_delegate.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	mojo/public/bindings/gles2_client/gles2_client_impl.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	mojo/public/bindings/gles2_client/gles2_client_impl.cc	View	4 chunks	+9 lines, -4 lines	0 comments	Download
M	mojo/services/gles2/gles2.mojom	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/gles2/gles2_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/gles2/gles2_impl.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/99323005/1

7 years ago (2013-12-02 20:23:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/99323005/1

7 years ago (2013-12-02 21:28:20 UTC) #4

Message was sent while issue was closed.

Change committed as 238223

Expand Messages | Collapse Messages