Issue 993203002: Remove the last bits of the Sky Inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 993203002: Remove the last bits of the Sky Inspector (Closed)

Created:
5 years, 9 months ago by eseidel

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the last bits of the Sky Inspector Unclear what if any of this we will want in the Dart world. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/101e8f9b03263594fbe3f6e6e8b831fc09a8c65a

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -52 lines)			Patch
M	sky/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/services/inspector/BUILD.gn	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	sky/services/inspector/inspector.mojom	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	sky/tools/debugger/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/tools/tester/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/viewer/BUILD.gn	View	3 chunks	+0 lines, -8 lines	0 comments	Download
D	sky/viewer/services/inspector.mojom	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 9 months ago (2015-03-11 17:13:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
101e8f9b03263594fbe3f6e6e8b831fc09a8c65a (presubmit successful).

Expand Messages | Collapse Messages