Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 993143002: Clarify warning for GYP variable merging. (Closed)

Created:
5 years, 9 months ago by scheib
Modified:
5 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dshwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify warning for GYP variable merging. https://codereview.chromium.org/931643002 changed variable merging behavior for environment variables and chromium.gyp_env. The new behavior replaces variables, with the exception of GYP_DEFINES which is instead concatenated. This change clarifies the state of the variables to the developer by printing values, and more accurately describes the override behavior as 'merges with, and individual components override,'. Committed: https://crrev.com/eedc9ac929470feba9b8b4899c1aad14cbb5b97b Cr-Commit-Position: refs/heads/master@{#320609}

Patch Set 1 #

Total comments: 2

Patch Set 2 : ' not " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M build/gyp_helper.py View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
scheib
5 years, 9 months ago (2015-03-10 22:32:48 UTC) #2
scheib
5 years, 9 months ago (2015-03-13 22:39:08 UTC) #4
scottmg
lgtm https://codereview.chromium.org/993143002/diff/1/build/gyp_helper.py File build/gyp_helper.py (right): https://codereview.chromium.org/993143002/diff/1/build/gyp_helper.py#newcode54 build/gyp_helper.py:54: string_padding = max(len(var), len(file_path), len("result")) ' not "
5 years, 9 months ago (2015-03-13 23:05:46 UTC) #5
scheib
https://codereview.chromium.org/993143002/diff/1/build/gyp_helper.py File build/gyp_helper.py (right): https://codereview.chromium.org/993143002/diff/1/build/gyp_helper.py#newcode54 build/gyp_helper.py:54: string_padding = max(len(var), len(file_path), len("result")) On 2015/03/13 23:05:45, scottmg ...
5 years, 9 months ago (2015-03-13 23:10:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993143002/20001
5 years, 9 months ago (2015-03-13 23:10:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993143002/40001
5 years, 9 months ago (2015-03-13 23:12:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-14 00:14:09 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 00:15:01 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eedc9ac929470feba9b8b4899c1aad14cbb5b97b
Cr-Commit-Position: refs/heads/master@{#320609}

Powered by Google App Engine
This is Rietveld 408576698