Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 99313002: Remove TreatNullAs=NullString for HTMLOutputElement (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLOutputElement http://whatwg.org/html#htmloutputelement The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: IE does not support HTMLOutputElement at all. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M LayoutTests/fast/dom/domstring-attribute-reflection.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOutputElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-02 15:50:13 UTC) #1
arv (Not doing code reviews)
LGTM
7 years ago (2013-12-02 15:57:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/99313002/1
7 years ago (2013-12-02 16:04:21 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 17:05:19 UTC) #4
Message was sent while issue was closed.
Change committed as 163002

Powered by Google App Engine
This is Rietveld 408576698