Issue 993123002: Generate the commit message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 993123002: Generate the commit message (Closed)

Created:
5 years, 9 months ago by Johann

Modified:
5 years, 9 months ago

Reviewers:
Tom Finegan

CC:
wwcv, jzern, fgalligan1, Tom Finegan

Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Generate the commit message Also remind the person to update README.chromium R=tomfinegan@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/691bdf36de033eaf7a3d12597592306a496cd8b7

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
	M	update_libvpx.sh	View		3 chunks	+30 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johann

Output looks like this: Update README.chromium: =============== Date: Tuesday March 10 2015 Branch: master Commit: ...

5 years, 9 months ago (2015-03-10 22:20:57 UTC) #1

Tom Finegan

lgtm https://codereview.chromium.org/993123002/diff/1/update_libvpx.sh File update_libvpx.sh (right): https://codereview.chromium.org/993123002/diff/1/update_libvpx.sh#newcode75 update_libvpx.sh:75: could have been a heredoc: cat << EOF ...

5 years, 9 months ago (2015-03-10 22:32:06 UTC) #2

Johann

5 years, 9 months ago (2015-03-11 20:01:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
691bdf36de033eaf7a3d12597592306a496cd8b7 (presubmit successful).

Expand Messages | Collapse Messages