Add tokeninfo call with token identified by token_handle parameter.

Add tokeninfo call with token identified by token_handle parameter.

See go/external-token-handle for details.

BUG=462445
R=rogerta@chromium.org

Committed: https://crrev.com/5a734aca8aec0dffbce8361fe883edd15c8e3fbd
Cr-Commit-Position: refs/heads/master@{#320151}

[Roger Tawa OOO till Jul 10th, 2015-03-11 18:23:52]

Thanks Denis.  A couple of comments below.

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
File google_apis/gaia/gaia_oauth_client.cc (right):

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
google_apis/gaia/gaia_oauth_client.cc:219: }
Since Core is an internal only class, and since this is almost a complete dupe
of GaiaOAuthClient::Core::GetTokenInfo(), better to add an extra argument to
GaiaOAuthClient::Core::GetTokenInfo() with the "xxx=" string.

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
File google_apis/gaia/gaia_oauth_client_unittest.cc (right):

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
google_apis/gaia/gaia_oauth_client_unittest.cc:168: "\"token_handle\":\"" +
kTestAccessTokenHandle + "\","
Will all access tokens return a token_handle?  I don't see where this new part
of the string is tested in anything below.  Do we really need line 168?

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
google_apis/gaia/gaia_oauth_client_unittest.cc:412:
ASSERT_TRUE(captured_result->GetString("audience",  &audience));
nit: extra space before &audience

[Denis Kuznetsov (DE-MUC), 2015-03-11 19:04:19]

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
File google_apis/gaia/gaia_oauth_client.cc (right):

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
google_apis/gaia/gaia_oauth_client.cc:219: }
On 2015/03/11 18:23:52, Roger Tawa wrote:
> Since Core is an internal only class, and since this is almost a complete dupe
> of GaiaOAuthClient::Core::GetTokenInfo(), better to add an extra argument to
> GaiaOAuthClient::Core::GetTokenInfo() with the "xxx=" string.

Done.

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
File google_apis/gaia/gaia_oauth_client_unittest.cc (right):

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
google_apis/gaia/gaia_oauth_client_unittest.cc:168: "\"token_handle\":\"" +
kTestAccessTokenHandle + "\","
On 2015/03/11 18:23:52, Roger Tawa wrote:
> Will all access tokens return a token_handle?  I don't see where this new part
> of the string is tested in anything below.  Do we really need line 168?

As per design doc it will. However, before it goes to production let's remove
this.

https://codereview.chromium.org/993103002/diff/1/google_apis/gaia/gaia_oauth_...
google_apis/gaia/gaia_oauth_client_unittest.cc:412:
ASSERT_TRUE(captured_result->GetString("audience",  &audience));
On 2015/03/11 18:23:52, Roger Tawa wrote:
> nit: extra space before &audience

Done.

[Roger Tawa OOO till Jul 10th, 2015-03-11 19:36:22]

lgtm

Thanks Denis!

[Denis Kuznetsov (DE-MUC), 2015-03-11 20:11:28]

The CQ bit was checked by antrim@chromium.org

[commit-bot: I haz the power, 2015-03-11 20:11:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993103002/20001

[commit-bot: I haz the power, 2015-03-11 21:45:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-11 21:45:51]

Patchset 2 (id:??) landed as
https://crrev.com/5a734aca8aec0dffbce8361fe883edd15c8e3fbd
Cr-Commit-Position: refs/heads/master@{#320151}