Issue 99309: Fix a gcc 4.3 warning in page_action.h....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99309: Fix a gcc 4.3 warning in page_action.h.... (Closed)

Created:
11 years, 7 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a gcc 4.3 warning in page_action.h. Patch from Livio Soares <liviobs@gmail.com>;. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15126

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/common/page_action.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Why even use a typedef, doesn't enum Blah { } work just fine?

11 years, 7 months ago (2009-05-02 12:25:22 UTC) #1

Lei Zhang

11 years, 7 months ago (2009-05-05 17:49:21 UTC) #2

On 2009/05/02 12:25:22, Dean McNamee wrote:
> Why even use a typedef, doesn't
> 
> enum Blah { }
> 
> work just fine?

It's a C-ism. I forgot it's ok in C++.

Expand Messages | Collapse Messages