Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: test/mjsunit/es7/object-observe.js

Issue 993073002: [es6] Function length property should be configurable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix status file again Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/es6/function-length-configurable.js ('k') | test/mjsunit/regress/regress-1530.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1125 matching lines...) Expand 10 before | Expand all | Expand 10 after
1136 // createProxy(Proxy.create, null), 1136 // createProxy(Proxy.create, null),
1137 // createProxy(Proxy.createFunction, function(){}), 1137 // createProxy(Proxy.createFunction, function(){}),
1138 ]; 1138 ];
1139 var properties = ["a", "1", 1, "length", "setPrototype", "name", "caller"]; 1139 var properties = ["a", "1", 1, "length", "setPrototype", "name", "caller"];
1140 1140
1141 // Cases that yield non-standard results. 1141 // Cases that yield non-standard results.
1142 function blacklisted(obj, prop) { 1142 function blacklisted(obj, prop) {
1143 return (obj instanceof Int32Array && prop == 1) || 1143 return (obj instanceof Int32Array && prop == 1) ||
1144 (obj instanceof Int32Array && prop === "length") || 1144 (obj instanceof Int32Array && prop === "length") ||
1145 (obj instanceof ArrayBuffer && prop == 1) || 1145 (obj instanceof ArrayBuffer && prop == 1) ||
1146 (obj instanceof Function && prop === "name"); // Has its own test. 1146 (obj instanceof Function && prop === "name") || // Has its own test.
1147 (obj instanceof Function && prop === "length"); // Has its own test.
1147 } 1148 }
1148 1149
1149 for (var i in objects) for (var j in properties) { 1150 for (var i in objects) for (var j in properties) {
1150 var obj = objects[i]; 1151 var obj = objects[i];
1151 var prop = properties[j]; 1152 var prop = properties[j];
1152 if (blacklisted(obj, prop)) continue; 1153 if (blacklisted(obj, prop)) continue;
1153 var desc = Object.getOwnPropertyDescriptor(obj, prop); 1154 var desc = Object.getOwnPropertyDescriptor(obj, prop);
1154 print("***", typeof obj, stringifyNoThrow(obj), prop); 1155 print("***", typeof obj, stringifyNoThrow(obj), prop);
1155 if (!desc || desc.configurable) 1156 if (!desc || desc.configurable)
1156 TestObserveConfigurable(obj, prop); 1157 TestObserveConfigurable(obj, prop);
(...skipping 662 matching lines...) Expand 10 before | Expand all | Expand 10 after
1819 observer.assertCallbackRecords([ 1820 observer.assertCallbackRecords([
1820 { object: fun, type: 'update', name: 'name', oldValue: 'fun' }, 1821 { object: fun, type: 'update', name: 'name', oldValue: 'fun' },
1821 { object: fun, type: 'reconfigure', name: 'name'}, 1822 { object: fun, type: 'reconfigure', name: 'name'},
1822 { object: fun, type: 'update', name: 'name', oldValue: 'a' }, 1823 { object: fun, type: 'update', name: 'name', oldValue: 'a' },
1823 { object: fun, type: 'delete', name: 'name', oldValue: 'b' }, 1824 { object: fun, type: 'delete', name: 'name', oldValue: 'b' },
1824 { object: fun, type: 'add', name: 'name' }, 1825 { object: fun, type: 'add', name: 'name' },
1825 ]); 1826 ]);
1826 })(); 1827 })();
1827 1828
1828 1829
1830 (function TestFunctionLength() {
1831 reset();
1832
1833 function fun(x) {}
1834 Object.observe(fun, observer.callback);
1835 fun.length = 'x'; // No change. Not writable.
1836 Object.defineProperty(fun, 'length', {value: 'a'});
1837 Object.defineProperty(fun, 'length', {writable: true});
1838 fun.length = 'b';
1839 delete fun.length;
1840 fun.length = 'x'; // No change. Function.prototype.length is non writable
1841 Object.defineProperty(Function.prototype, 'length', {writable: true});
1842 fun.length = 'c';
1843 fun.length = 'c'; // Same, no update.
1844 Object.deliverChangeRecords(observer.callback);
1845 observer.assertCallbackRecords([
1846 { object: fun, type: 'update', name: 'length', oldValue: 1 },
1847 { object: fun, type: 'reconfigure', name: 'length'},
1848 { object: fun, type: 'update', name: 'length', oldValue: 'a' },
1849 { object: fun, type: 'delete', name: 'length', oldValue: 'b' },
1850 { object: fun, type: 'add', name: 'length' },
1851 ]);
1852 })();
1853
1854
1829 (function TestObserveInvalidAcceptMessage() { 1855 (function TestObserveInvalidAcceptMessage() {
1830 var ex; 1856 var ex;
1831 try { 1857 try {
1832 Object.observe({}, function(){}, "not an object"); 1858 Object.observe({}, function(){}, "not an object");
1833 } catch (e) { 1859 } catch (e) {
1834 ex = e; 1860 ex = e;
1835 } 1861 }
1836 assertInstanceof(ex, TypeError); 1862 assertInstanceof(ex, TypeError);
1837 assertEquals("Third argument to Object.observe must be an array of strings.", 1863 assertEquals("Third argument to Object.observe must be an array of strings.",
1838 ex.message); 1864 ex.message);
1839 })() 1865 })()
OLDNEW
« no previous file with comments | « test/mjsunit/es6/function-length-configurable.js ('k') | test/mjsunit/regress/regress-1530.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698