[es6] Function length property should be configurable

[es6] Function length property should be configurable

ES6 specs the function length property (it was not part of ES5) and
it makes it configurable.

BUG=v8:3045
LOG=N
R=mstarzinger@chromium.org, adamk@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/e62584464873264c72c386170fe7fa8dce926833
Cr-Commit-Position: refs/heads/master@{#27190}

[arv (Not doing code reviews), 2015-03-10 19:37:55]

Fix test/webkit

[arv (Not doing code reviews), 2015-03-10 22:37:29]

Refactor to share more code

[arv (Not doing code reviews), 2015-03-10 22:41:23]

PTAL

Here is the Blink CL that disables the Blink tests so this does not prevent a
roll.

https://codereview.chromium.org/993073002/diff/40001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/993073002/diff/40001/src/accessors.cc#newcode...
src/accessors.cc:1098: MUST_USE_RESULT static MaybeHandle<Object>
ReplaceAccessorWithDataProperty(
I could reuse more code by either using a macro or function pointers. WDYT?

[arv (Not doing code reviews), 2015-03-10 22:41:48]

PTAL

Here is the Blink CL that disables the Blink tests so this does not prevent a
roll:

https://codereview.chromium.org/997673002/

[adamk, 2015-03-10 22:49:51]

lgtm

https://codereview.chromium.org/993073002/diff/40001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/993073002/diff/40001/src/accessors.cc#newcode...
src/accessors.cc:1098: MUST_USE_RESULT static MaybeHandle<Object>
ReplaceAccessorWithDataProperty(
On 2015/03/10 22:41:23, arv wrote:
> I could reuse more code by either using a macro or function pointers. WDYT?

I don't think this is quite enough repetition here to be worth using a macro,
but we'll see what mstarzinger thinks.

[Michael Starzinger, 2015-03-11 09:35:23]

LGTM.

https://codereview.chromium.org/993073002/diff/40001/src/accessors.cc
File src/accessors.cc (right):

https://codereview.chromium.org/993073002/diff/40001/src/accessors.cc#newcode...
src/accessors.cc:1098: MUST_USE_RESULT static MaybeHandle<Object>
ReplaceAccessorWithDataProperty(
On 2015/03/10 22:49:51, adamk wrote:
> On 2015/03/10 22:41:23, arv wrote:
> > I could reuse more code by either using a macro or function pointers. WDYT?
> 
> I don't think this is quite enough repetition here to be worth using a macro,
> but we'll see what mstarzinger thinks.

Acknowledged. I agree with Adam, I don't think the repetition warrants a macro
yet.

[arv (Not doing code reviews), 2015-03-11 12:28:01]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-03-11 12:35:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993073002/40001

[commit-bot: I haz the power, 2015-03-11 13:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 13:18:09]

Try jobs failed on following builders:
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/3707)

[arv (Not doing code reviews), 2015-03-11 13:23:17]

On 2015/03/11 13:18:09, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_linux_rel on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/3707)

Of course. test262 and Mozilla has tests for this.

[arv (Not doing code reviews), 2015-03-11 14:11:11]

Disable tests :'(

[arv (Not doing code reviews), 2015-03-11 14:19:31]

I had  to disable more than 100 test262 tests. I'll be working on fixing these
tests upstream.

https://codereview.chromium.org/993073002/diff/60001/test/test262-es6/test262...
File test/test262-es6/test262-es6.status (right):

https://codereview.chromium.org/993073002/diff/60001/test/test262-es6/test262...
test/test262-es6/test262-es6.status:177: # Function length properties are
configurable in ES6
This is sad.

However, most a lot of these tests fail because they use an utily function,
testBuiltInObject which incorrectly checks the configurability.

[arv (Not doing code reviews), 2015-03-11 14:50:15]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-03-11 14:50:15]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/993073002/#ps60001 (title:
"Disable tests :'(")

[commit-bot: I haz the power, 2015-03-11 14:50:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993073002/60001

[commit-bot: I haz the power, 2015-03-12 00:57:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-12 00:57:46]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/5...)

[arv (Not doing code reviews), 2015-03-12 18:24:08]

Update status file to new format

[arv (Not doing code reviews), 2015-03-12 18:26:56]

sort exceptions again

[arv (Not doing code reviews), 2015-03-12 19:55:39]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-03-12 19:55:40]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/993073002/#ps100001
(title: "sort exceptions again")

[commit-bot: I haz the power, 2015-03-12 19:55:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993073002/100001

[commit-bot: I haz the power, 2015-03-12 19:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-12 19:57:15]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/3751)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/2314)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/2904)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[arv (Not doing code reviews), 2015-03-12 20:28:36]

git rebase

[arv (Not doing code reviews), 2015-03-12 20:28:44]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-03-12 20:28:45]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/993073002/#ps120001
(title: "git rebase")

[commit-bot: I haz the power, 2015-03-12 20:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993073002/120001

[commit-bot: I haz the power, 2015-03-12 21:01:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-12 21:01:30]

Try jobs failed on following builders:
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/3783)

[arv (Not doing code reviews), 2015-03-13 13:15:14]

On 2015/03/12 21:01:30, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_linux_rel on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/3783)

The bot was not using the latest testcf.py. Trying again.

[arv (Not doing code reviews), 2015-03-13 13:15:19]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-03-13 13:15:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993073002/120001

[commit-bot: I haz the power, 2015-03-13 14:11:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-13 14:11:06]

Try jobs failed on following builders:
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/3816)

[arv (Not doing code reviews), 2015-03-13 15:40:43]

Fix status file again

[arv (Not doing code reviews), 2015-03-13 15:41:42]

On 2015/03/13 15:40:43, arv wrote:
> Fix status file again

Stoopid me... I had a different version of test262 checked out when I updated
this the last time.

[arv (Not doing code reviews), 2015-03-13 15:41:46]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-03-13 15:41:46]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/993073002/#ps140001
(title: "Fix status file again")

[commit-bot: I haz the power, 2015-03-13 15:42:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/993073002/140001

[commit-bot: I haz the power, 2015-03-13 17:19:46]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-03-13 17:20:01]

Patchset 8 (id:??) landed as
https://crrev.com/e62584464873264c72c386170fe7fa8dce926833
Cr-Commit-Position: refs/heads/master@{#27190}