Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 993033003: Move example fn widgets into sky/framework/components (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move example fn widgets into sky/framework/components Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/be455d9ce8e0464081047e0506d59ef7990430d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -1083 lines) Patch
D sky/examples/fn/widgets/box.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D sky/examples/fn/widgets/button.dart View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/examples/fn/widgets/buttonbase.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/examples/fn/widgets/checkbox.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/examples/fn/widgets/drawer.dart View 1 chunk +0 lines, -159 lines 0 comments Download
D sky/examples/fn/widgets/drawerheader.dart View 1 chunk +0 lines, -46 lines 0 comments Download
D sky/examples/fn/widgets/fixedheightscrollable.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D sky/examples/fn/widgets/floating_action_button.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D sky/examples/fn/widgets/icon.dart View 1 chunk +0 lines, -34 lines 0 comments Download
D sky/examples/fn/widgets/inksplash.dart View 1 chunk +0 lines, -96 lines 0 comments Download
D sky/examples/fn/widgets/material.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D sky/examples/fn/widgets/menudivider.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D sky/examples/fn/widgets/menuitem.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/examples/fn/widgets/radio.dart View 1 chunk +0 lines, -59 lines 0 comments Download
D sky/examples/fn/widgets/toolbar.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D sky/examples/fn/widgets/widgets.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M sky/examples/stocks-fn/stockrow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks-fn/stocksapp.dart View 1 chunk +9 lines, -1 line 0 comments Download
A + sky/framework/components/button.dart View 3 chunks +9 lines, -6 lines 0 comments Download
A + sky/framework/components/button_base.dart View 2 chunks +10 lines, -6 lines 0 comments Download
A + sky/framework/components/checkbox.dart View 6 chunks +24 lines, -16 lines 0 comments Download
A + sky/framework/components/drawer.dart View 7 chunks +22 lines, -12 lines 0 comments Download
A + sky/framework/components/drawer_header.dart View 2 chunks +9 lines, -5 lines 0 comments Download
A + sky/framework/components/fixed_height_scrollable.dart View 3 chunks +16 lines, -10 lines 0 comments Download
A + sky/framework/components/floating_action_button.dart View 1 chunk +9 lines, -2 lines 0 comments Download
A + sky/framework/components/icon.dart View 1 chunk +5 lines, -2 lines 0 comments Download
A + sky/framework/components/ink_splash.dart View 4 chunks +13 lines, -6 lines 0 comments Download
A + sky/framework/components/material.dart View 3 chunks +15 lines, -7 lines 0 comments Download
A + sky/framework/components/menu_divider.dart View 1 chunk +6 lines, -3 lines 0 comments Download
A + sky/framework/components/menu_item.dart View 4 chunks +12 lines, -7 lines 0 comments Download
A + sky/framework/components/radio.dart View 4 chunks +16 lines, -8 lines 0 comments Download
A + sky/framework/components/toolbar.dart View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-10 22:55:04 UTC) #1
abarth-chromium
5 years, 9 months ago (2015-03-10 22:55:27 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
be455d9ce8e0464081047e0506d59ef7990430d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698