chrome/browser/password_manager/password_store_mac.cc - Issue 99303009: Merge 241255 "[Mac] Passwords: Don't always prompt to access pas..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.cc

Issue 99303009: Merge 241255 "[Mac] Passwords: Don't always prompt to access pas..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1750/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_mac.h ('k') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac.cc

===================================================================

--- chrome/browser/password_manager/password_store_mac.cc (revision 241838)

+++ chrome/browser/password_manager/password_store_mac.cc (working copy)

@@ -20,6 +20,7 @@

#include "base/strings/string_util.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/chrome_notification_types.h"

+#include "chrome/browser/mac/security_wrappers.h"

#include "chrome/browser/password_manager/login_database.h"

#include "chrome/browser/password_manager/password_store_change.h"

#include "content/public/browser/notification_service.h"

@@ -979,7 +980,11 @@

void PasswordStoreMac::GetLoginsImpl(

const autofill::PasswordForm& form,

+ AuthorizationPromptPolicy prompt_policy,

const ConsumerCallbackRunner& callback_runner) {

+ chrome::ScopedSecKeychainSetUserInteractionAllowed user_interaction_allowed(

+ prompt_policy == ALLOW_PROMPT);

MacKeychainPasswordFormAdapter keychain_adapter(keychain_.get());

std::vector<PasswordForm*> keychain_forms =

keychain_adapter.PasswordsFillingForm(form);