Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 99303009: Merge 241255 "[Mac] Passwords: Don't always prompt to access pas..." (Closed)

Created:
7 years ago by Patrick Dubroy
Modified:
7 years ago
Reviewers:
Patrick Dubroy
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Merge 241255 "[Mac] Passwords: Don't always prompt to access pas..." > [Mac] Passwords: Don't always prompt to access passwords saved by other browsers > > Disable Keychain password access prompts when Chrome's "Ask to save passwords" > option is disabled. This gives users an escape hatch other than clicking > "Always allow" or "Deny" for each password prompt when they have passwords > saved from other browsers. This previously regressed with http://crrev.com/166878. > > R=stuartmorgan@chromium.org > TBR=atwilson@chromium.org > BUG=178358 > TEST= > 1. In *Safari*, navigate to a login page for which you can save a password. > 2. Log in, and instruct Safari to save the password. > 3. In *Chrome*, under Advanced Settings, disable password management. > 4. Navigate to the same login page. > At step (4), there should be no prompt for authorization to access the > password saved in Safari. > > Review URL: https://codereview.chromium.org/106053008 TBR=dubroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -53 lines) Patch
M chrome/browser/password_manager/mock_password_store.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_form_manager.h View 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_form_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_form_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager_unittest.cc View 13 chunks +27 lines, -26 lines 0 comments Download
M chrome/browser/password_manager/password_store.h View 3 chunks +14 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_default.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_default.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_x.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/test_password_store.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/test_password_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/passwords_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Patrick Dubroy
7 years ago (2013-12-19 11:50:38 UTC) #1
Patrick Dubroy
7 years ago (2013-12-19 11:53:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r241843.

Powered by Google App Engine
This is Rietveld 408576698