Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 99303003: SkDiscardablePixelRef objects are now marked immutable. (Closed)

Created:
7 years ago by hal.canary
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

SkDiscardablePixelRef objects are now marked immutable. I also specifically mentioned in the SkImageGenerator documentation that it should always return the same information on subsequent calls to getInfo() and getPixels(). Motivation: When a bitmap is recorded into a SkPicture, it will choose whether to shallow- or deep-copy itself into the SkBitmapHeap based on the immutable flag. Failing to set it would make picture recording slow. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M include/core/SkImageGenerator.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hal.canary
7 years ago (2013-12-02 18:30:40 UTC) #1
reed1
lgtm -- if we need to in the future, we could have a virtual on ...
7 years ago (2013-12-02 18:36:36 UTC) #2
reed1
I take it back -- it should *always* be immutable
7 years ago (2013-12-02 18:37:26 UTC) #3
scroggo
On 2013/12/02 18:37:26, reed1 wrote: > I take it back -- it should *always* be ...
7 years ago (2013-12-02 19:39:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/99303003/1
7 years ago (2013-12-02 21:15:43 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-02 22:32:55 UTC) #6
Message was sent while issue was closed.
Change committed as 12445

Powered by Google App Engine
This is Rietveld 408576698