Issue 993003004: Delete flaky benchmark test

Issue 993003004: Delete flaky benchmark test (Closed)

Created:
5 years, 9 months ago by JF

Modified:
5 years, 9 months ago

Reviewers:
bradnelson, bradn

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Delete flaky benchmark test These tests have been flaking for months and have gone unfixed, deleting them seems like the right thing to do. R= bradnelson@chromium.org BUG= flaky tests TEST= ./scons run_benchmark_test Committed: https://chromium.googlesource.com/native_client/src/native_client/+/48faafec21d8a14fbb9ab3ac6f40ab495beb0809

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -771 lines)			Patch
D	src/third_party/computer_language_benchmarks_game/README	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	src/third_party/computer_language_benchmarks_game/binarytrees.c	View		1 chunk	+0 lines, -137 lines	0 comments	Download
D	src/third_party/computer_language_benchmarks_game/chameneos.c	View		1 chunk	+0 lines, -302 lines	0 comments	Download
D	src/third_party/computer_language_benchmarks_game/nbody.c	View		1 chunk	+0 lines, -169 lines	0 comments	Download
D	tests/benchmark/DEPS	View		1 chunk	+0 lines, -4 lines	0 comments	Download
D	tests/benchmark/benchmark_binarytrees.cc	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	tests/benchmark/benchmark_binarytrees_c.c	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	tests/benchmark/benchmark_chameneos.cc	View		1 chunk	+0 lines, -36 lines	0 comments	Download
D	tests/benchmark/benchmark_chameneos_c.c	View		1 chunk	+0 lines, -13 lines	0 comments	Download
M	tests/benchmark/benchmark_life.cc	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
D	tests/benchmark/benchmark_nbody.cc	View		1 chunk	+0 lines, -37 lines	0 comments	Download
D	tests/benchmark/benchmark_nbody_c.c	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	tests/benchmark/framework.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/benchmark/nacl.scons	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	tests/benchmark/thread_pool.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

bradn

lgtm, a little sad to see it go, but getting in our light. Figure out ...

5 years, 9 months ago (2015-03-10 21:47:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/993003004/20001

5 years, 9 months ago (2015-03-10 23:36:04 UTC) #6

commit-bot: I haz the power

5 years, 9 months ago (2015-03-11 06:31:18 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/native_client/src/native_client/+/48faafec2...