Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 992973002: Small fixes (Closed)

Created:
5 years, 9 months ago by vsm
Modified:
5 years, 9 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M lib/src/codegen/js_codegen.dart View 2 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 4 (1 generated)
vsm
https://codereview.chromium.org/992973002/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/992973002/diff/1/lib/src/codegen/js_codegen.dart#newcode1520 lib/src/codegen/js_codegen.dart:1520: var catchBody = new JS.Block(_visitList(clauses)); The js ast code ...
5 years, 9 months ago (2015-03-10 13:34:47 UTC) #2
Jennifer Messerly
lgtm https://codereview.chromium.org/992973002/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/992973002/diff/1/lib/src/codegen/js_codegen.dart#newcode1520 lib/src/codegen/js_codegen.dart:1520: var catchBody = new JS.Block(_visitList(clauses)); On 2015/03/10 13:34:47, ...
5 years, 9 months ago (2015-03-10 15:04:08 UTC) #3
vsm
5 years, 9 months ago (2015-03-10 17:25:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8320da95c7821cb4f807886a3280053e0b0fa114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698