Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Issue 992963002: bindings: Adds missing [Unforgeable] extended attributes. (Closed)

Created:
5 years, 9 months ago by Yuki
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Adds missing [Unforgeable] extended attributes. As the spec specifies, makes Window.document and Location.ancestorOrigins [Unforgeable]. BUG=43394 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/frame/Location.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL?
5 years, 9 months ago (2015-03-10 13:02:52 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-10 15:42:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992963002/1
5 years, 9 months ago (2015-03-11 04:07:13 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 04:09:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191676

Powered by Google App Engine
This is Rietveld 408576698