handle the special snowflakes that are Integer Indexed Exotic objects

src/lookup.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/bootstrapper.h"
 #include "src/deoptimizer.h"
 #include "src/lookup.h"
 #include "src/lookup-inl.h"
@@ skipping 103 matching lines @@
 
   ReloadPropertyInformation();
 }
 
 
 void LookupIterator::PrepareTransitionToDataProperty(
     Handle<Object> value, PropertyAttributes attributes,
     Object::StoreFromKeyed store_mode) {
   if (state_ == TRANSITION) return;
   DCHECK(state_ != LookupIterator::ACCESSOR);
+  DCHECK(state_ != LookupIterator::INTEGER_INDEXED_EXOTIC);

[Toon Verwaest, 2015/03/10 12:01:25]

DCHECK_NE

[dcarney, 2015/03/10 13:09:46]

Done.

   DCHECK(state_ == NOT_FOUND || !HolderIsReceiverOrHiddenPrototype());
-  DCHECK(!IsSpecialNumericIndex());
   // Can only be called when the receiver is a JSObject. JSProxy has to be
   // handled via a trap. Adding properties to primitive values is not
   // observable.
   Handle<JSObject> receiver = GetStoreTarget();
 
   if (!isolate()->IsInternallyUsedPropertyName(name()) &&
       !receiver->map()->is_extensible()) {
     return;
   }
 
@@ skipping 190 matching lines @@
     }
   } else if (property_details_.type() == v8::internal::DATA) {
     holder->WriteToField(descriptor_number(), *value);
   } else {
     DCHECK_EQ(v8::internal::DATA_CONSTANT, property_details_.type());
   }
   return value;
 }
 
 
-bool LookupIterator::IsSpecialNumericIndex() const {
-  if (GetStoreTarget()->IsJSTypedArray() && name()->IsString()) {
-    Handle<String> name_string = Handle<String>::cast(name());
-    if (name_string->length() > 0) {
-      double d =
-          StringToDouble(isolate()->unicode_cache(), name_string, NO_FLAGS);
-      if (!std::isnan(d)) {
-        if (String::Equals(isolate()->factory()->minus_zero_string(),
-                           name_string))
-          return true;
-
-        Factory* factory = isolate()->factory();
-        Handle<Object> num = factory->NewNumber(d);
-        Handle<String> roundtrip_string = factory->NumberToString(num);
-        if (String::Equals(name_string, roundtrip_string)) return true;
-      }
+bool LookupIterator::IsIntegerIndexedExotic(JSReceiver* holder) {
+  DCHECK(exotic_index_state_ != ExoticIndexState::kNoIndex);

[Toon Verwaest, 2015/03/10 12:01:25]

DCHECK_NE

[dcarney, 2015/03/10 13:09:46]

dcheck not okay with this

+  if (!holder->IsJSTypedArray()) return false;
+  if (exotic_index_state_ == ExoticIndexState::kIndex) return true;
+  DCHECK(exotic_index_state_ == ExoticIndexState::kUninitialized);

[Toon Verwaest, 2015/03/10 12:01:25]

DCHECK_EQ

[dcarney, 2015/03/10 13:09:46]

same

+  if (!name()->IsString() || String::cast(*name())->length() == 0) {
+    exotic_index_state_ = ExoticIndexState::kNoIndex;
+    return false;
+  }
+  Handle<String> name_string = Handle<String>::cast(name());
+  double d = StringToDouble(isolate()->unicode_cache(), name_string, NO_FLAGS);
+  if (!std::isnan(d)) {
+    if (String::Equals(isolate()->factory()->minus_zero_string(),
+                       name_string)) {
+      exotic_index_state_ = ExoticIndexState::kIndex;
+      return true;
+    }
+    // TODO(dcarney): this could be a lot faster.
+    AllowHeapAllocation allow;

[Toon Verwaest, 2015/03/10 12:01:25]

Arg, reallowing allocation is crazy... that's going  to cause bugs.
Just write a local integer parser instead. The current impl even seems wrong.
E.g., "2e+60" is handled as IntegerIndexedExotic, while I presume it shouldn't
be.

[dcarney, 2015/03/10 13:09:46]

Done.

+    Factory* factory = isolate()->factory();
+    Handle<Object> num = factory->NewNumber(d);
+    Handle<String> roundtrip_string = factory->NumberToString(num);
+    if (String::Equals(name_string, roundtrip_string)) {
+      exotic_index_state_ = ExoticIndexState::kIndex;
+      return true;
     }
   }
+  exotic_index_state_ = ExoticIndexState::kNoIndex;
   return false;
 }
 
 
 void LookupIterator::InternalizeName() {
   if (name_->IsUniqueName()) return;
   name_ = factory()->InternalizeString(Handle<String>::cast(name_));
 }
 } }  // namespace v8::internal