Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 992913002: handle the special snowflakes that are Integer Indexed Exotic objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-conversions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 static Handle<Object> DebugGetProperty(LookupIterator* it, 65 static Handle<Object> DebugGetProperty(LookupIterator* it,
66 bool* has_caught = NULL) { 66 bool* has_caught = NULL) {
67 for (; it->IsFound(); it->Next()) { 67 for (; it->IsFound(); it->Next()) {
68 switch (it->state()) { 68 switch (it->state()) {
69 case LookupIterator::NOT_FOUND: 69 case LookupIterator::NOT_FOUND:
70 case LookupIterator::TRANSITION: 70 case LookupIterator::TRANSITION:
71 UNREACHABLE(); 71 UNREACHABLE();
72 case LookupIterator::ACCESS_CHECK: 72 case LookupIterator::ACCESS_CHECK:
73 // Ignore access checks. 73 // Ignore access checks.
74 break; 74 break;
75 case LookupIterator::INTEGER_INDEXED_EXOTIC:
75 case LookupIterator::INTERCEPTOR: 76 case LookupIterator::INTERCEPTOR:
76 case LookupIterator::JSPROXY: 77 case LookupIterator::JSPROXY:
77 return it->isolate()->factory()->undefined_value(); 78 return it->isolate()->factory()->undefined_value();
78 case LookupIterator::ACCESSOR: { 79 case LookupIterator::ACCESSOR: {
79 Handle<Object> accessors = it->GetAccessors(); 80 Handle<Object> accessors = it->GetAccessors();
80 if (!accessors->IsAccessorInfo()) { 81 if (!accessors->IsAccessorInfo()) {
81 return it->isolate()->factory()->undefined_value(); 82 return it->isolate()->factory()->undefined_value();
82 } 83 }
83 MaybeHandle<Object> maybe_result = JSObject::GetPropertyWithAccessor( 84 MaybeHandle<Object> maybe_result = JSObject::GetPropertyWithAccessor(
84 it->GetReceiver(), it->name(), it->GetHolder<JSObject>(), 85 it->GetReceiver(), it->name(), it->GetHolder<JSObject>(),
(...skipping 2726 matching lines...) Expand 10 before | Expand all | Expand 10 after
2811 return Smi::FromInt(isolate->debug()->is_active()); 2812 return Smi::FromInt(isolate->debug()->is_active());
2812 } 2813 }
2813 2814
2814 2815
2815 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 2816 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
2816 UNIMPLEMENTED(); 2817 UNIMPLEMENTED();
2817 return NULL; 2818 return NULL;
2818 } 2819 }
2819 } 2820 }
2820 } // namespace v8::internal 2821 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-conversions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698