Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Side by Side Diff: src/ic/handler-compiler.cc

Issue 992913002: handle the special snowflakes that are Integer Indexed Exotic objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/cpu-profiler.h" 7 #include "src/cpu-profiler.h"
8 #include "src/ic/call-optimization.h" 8 #include "src/ic/call-optimization.h"
9 #include "src/ic/handler-compiler.h" 9 #include "src/ic/handler-compiler.h"
10 #include "src/ic/ic.h" 10 #include "src/ic/ic.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 // ExecutableAccessorInfo, so inline only them. Other cases may be added 273 // ExecutableAccessorInfo, so inline only them. Other cases may be added
274 // later. 274 // later.
275 bool inline_followup = false; 275 bool inline_followup = false;
276 switch (it->state()) { 276 switch (it->state()) {
277 case LookupIterator::TRANSITION: 277 case LookupIterator::TRANSITION:
278 UNREACHABLE(); 278 UNREACHABLE();
279 case LookupIterator::ACCESS_CHECK: 279 case LookupIterator::ACCESS_CHECK:
280 case LookupIterator::INTERCEPTOR: 280 case LookupIterator::INTERCEPTOR:
281 case LookupIterator::JSPROXY: 281 case LookupIterator::JSPROXY:
282 case LookupIterator::NOT_FOUND: 282 case LookupIterator::NOT_FOUND:
283 case LookupIterator::INTEGER_INDEXED_EXOTIC:
283 break; 284 break;
284 case LookupIterator::DATA: 285 case LookupIterator::DATA:
285 inline_followup = 286 inline_followup =
286 it->property_details().type() == DATA && !it->is_dictionary_holder(); 287 it->property_details().type() == DATA && !it->is_dictionary_holder();
287 break; 288 break;
288 case LookupIterator::ACCESSOR: { 289 case LookupIterator::ACCESSOR: {
289 Handle<Object> accessors = it->GetAccessors(); 290 Handle<Object> accessors = it->GetAccessors();
290 if (accessors->IsExecutableAccessorInfo()) { 291 if (accessors->IsExecutableAccessorInfo()) {
291 Handle<ExecutableAccessorInfo> info = 292 Handle<ExecutableAccessorInfo> info =
292 Handle<ExecutableAccessorInfo>::cast(accessors); 293 Handle<ExecutableAccessorInfo>::cast(accessors);
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 Register reg = FrontendHeader(interceptor_reg, it->name(), &miss); 340 Register reg = FrontendHeader(interceptor_reg, it->name(), &miss);
340 FrontendFooter(it->name(), &miss); 341 FrontendFooter(it->name(), &miss);
341 // We discard the vector and slot now because we don't miss below this point. 342 // We discard the vector and slot now because we don't miss below this point.
342 InterceptorVectorSlotPop(reg, DISCARD); 343 InterceptorVectorSlotPop(reg, DISCARD);
343 344
344 switch (it->state()) { 345 switch (it->state()) {
345 case LookupIterator::ACCESS_CHECK: 346 case LookupIterator::ACCESS_CHECK:
346 case LookupIterator::INTERCEPTOR: 347 case LookupIterator::INTERCEPTOR:
347 case LookupIterator::JSPROXY: 348 case LookupIterator::JSPROXY:
348 case LookupIterator::NOT_FOUND: 349 case LookupIterator::NOT_FOUND:
350 case LookupIterator::INTEGER_INDEXED_EXOTIC:
349 case LookupIterator::TRANSITION: 351 case LookupIterator::TRANSITION:
350 UNREACHABLE(); 352 UNREACHABLE();
351 case LookupIterator::DATA: { 353 case LookupIterator::DATA: {
352 DCHECK_EQ(DATA, it->property_details().type()); 354 DCHECK_EQ(DATA, it->property_details().type());
353 __ Move(receiver(), reg); 355 __ Move(receiver(), reg);
354 LoadFieldStub stub(isolate(), it->GetFieldIndex()); 356 LoadFieldStub stub(isolate(), it->GetFieldIndex());
355 GenerateTailCall(masm(), stub.GetCode()); 357 GenerateTailCall(masm(), stub.GetCode());
356 break; 358 break;
357 } 359 }
358 case LookupIterator::ACCESSOR: 360 case LookupIterator::ACCESSOR:
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
513 DCHECK(elements_kind == DICTIONARY_ELEMENTS); 515 DCHECK(elements_kind == DICTIONARY_ELEMENTS);
514 cached_stub = LoadDictionaryElementStub(isolate()).GetCode(); 516 cached_stub = LoadDictionaryElementStub(isolate()).GetCode();
515 } 517 }
516 } 518 }
517 519
518 handlers->Add(cached_stub); 520 handlers->Add(cached_stub);
519 } 521 }
520 } 522 }
521 } 523 }
522 } // namespace v8::internal 524 } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698