Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 992903002: Oilpan: implement StyleRuleList without an extra wrapper. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: implement StyleRuleList without an extra wrapper. Wrapping up a possibly-shared heap object behind a wrapper doesn't make sense with Oilpan, so do not provide it. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198068

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop use of transition type #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M Source/core/css/ElementRuleCollector.h View 1 2 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/css/ElementRuleCollector.cpp View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
fyi, not worth going ahead with just now. A speculative little change made to see ...
5 years, 9 months ago (2015-03-10 15:35:11 UTC) #2
haraken
LGTM https://codereview.chromium.org/992903002/diff/1/Source/core/css/ElementRuleCollector.h File Source/core/css/ElementRuleCollector.h (right): https://codereview.chromium.org/992903002/diff/1/Source/core/css/ElementRuleCollector.h#newcode89 Source/core/css/ElementRuleCollector.h:89: class StyleRuleList final : public RefCountedWillBeGarbageCollected<StyleRuleList> { RefCountedWillBeGarbageCollected ...
5 years, 9 months ago (2015-03-10 16:16:06 UTC) #4
sof
https://codereview.chromium.org/992903002/diff/1/Source/core/css/ElementRuleCollector.h File Source/core/css/ElementRuleCollector.h (right): https://codereview.chromium.org/992903002/diff/1/Source/core/css/ElementRuleCollector.h#newcode89 Source/core/css/ElementRuleCollector.h:89: class StyleRuleList final : public RefCountedWillBeGarbageCollected<StyleRuleList> { On 2015/03/10 ...
5 years, 9 months ago (2015-03-11 10:53:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992903002/40001
5 years, 5 months ago (2015-06-30 13:23:30 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-06-30 15:59:15 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198068

Powered by Google App Engine
This is Rietveld 408576698