Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3229)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java

Issue 992833002: Move minor WebViewChromium implementation to chromium layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
index f36742c6b2d3d6d43a13089f1abc6da5e64397fb..b96e35ef57587740a80e33e0f51d2853ed0c912a 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
@@ -31,7 +31,6 @@ import android.view.inputmethod.EditorInfo;
import android.view.inputmethod.InputConnection;
import android.webkit.DownloadListener;
import android.webkit.FindActionModeCallback;
-import android.webkit.JavascriptInterface;
import android.webkit.ValueCallback;
import android.webkit.WebBackForwardList;
import android.webkit.WebChromeClient;
@@ -51,7 +50,6 @@ import org.chromium.content.browser.SmartClipProvider;
import java.io.BufferedWriter;
import java.io.File;
-import java.lang.annotation.Annotation;
import java.util.Map;
import java.util.Queue;
import java.util.concurrent.Callable;
@@ -879,9 +877,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
});
return ret;
}
- String url = mAwContents.getUrl();
- if (url == null || url.trim().isEmpty()) return null;
- return url;
+ return mAwContents.getUrl();
}
@Override
@@ -896,9 +892,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
});
return ret;
}
- String url = mAwContents.getOriginalUrl();
- if (url == null || url.trim().isEmpty()) return null;
- return url;
+ return mAwContents.getOriginalUrl();
}
@Override
@@ -1299,11 +1293,7 @@ class WebViewChromium implements WebViewProvider, WebViewProvider.ScrollDelegate
});
return;
}
- Class<? extends Annotation> requiredAnnotation = null;
- if (mAppTargetSdkVersion >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
- requiredAnnotation = JavascriptInterface.class;
- }
- mAwContents.addPossiblyUnsafeJavascriptInterface(obj, interfaceName, requiredAnnotation);
+ mAwContents.addJavascriptInterface(obj, interfaceName);
}
@Override
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698