Move minor WebViewChromium implementation to chromium layer

Move minor WebViewChromium implementation to chromium layer

getUrl/getOriginalUrl logic already implemented in chromium layer.
Move js interface annotation to chromium layer, and fix tests that
did not have @JavascriptInterface annotation.

BUG=464491
Committed: https://crrev.com/6a5a246814adb820e6daf1de37215d3047bb3831
Cr-Commit-Position: refs/heads/master@{#319880}

[boliu, 2015-03-10 02:22:24]

boliu@chromium.org changed reviewers:
+ mnaganov@chromium.org

[boliu, 2015-03-10 02:22:24]

AddJavascriptInterface is your specialty again :)

I think this is the last trivial refactors

[mnaganov (inactive), 2015-03-10 09:53:58]

LGTM % method rename

https://codereview.chromium.org/992833002/diff/20001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/992833002/diff/20001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2126:
public void addPossiblyUnsafeJavascriptInterface(Object object, String name) {
I think you should rename this method to just 'addJavascriptInterface', because
'PossiblyUnsafe' was there due to the fact that you could specify 'null' as the
annotation, and that would expose all the methods of your Java class, which is
unsafe. And now you can't do that.

[boliu, 2015-03-10 14:34:01]

https://codereview.chromium.org/992833002/diff/20001/android_webview/java/src...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/992833002/diff/20001/android_webview/java/src...
android_webview/java/src/org/chromium/android_webview/AwContents.java:2126:
public void addPossiblyUnsafeJavascriptInterface(Object object, String name) {
On 2015/03/10 09:53:58, mnaganov (cr) wrote:
> I think you should rename this method to just 'addJavascriptInterface',
because
> 'PossiblyUnsafe' was there due to the fact that you could specify 'null' as
the
> annotation, and that would expose all the methods of your Java class, which is
> unsafe. And now you can't do that.

Done.

And it's more like UnsafeWhenTargetLessThanJBMR1, but whatever :p

[boliu, 2015-03-10 14:45:31]

cts WebViewTest still pass

[boliu, 2015-03-10 14:45:41]

The CQ bit was checked by boliu@chromium.org

[boliu, 2015-03-10 14:45:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnaganov@chromium.org
Link to the patchset: https://codereview.chromium.org/992833002/#ps40001 (title:
"rename")

[commit-bot: I haz the power, 2015-03-10 14:46:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/992833002/40001

[commit-bot: I haz the power, 2015-03-10 15:13:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-10 15:14:13]

Patchset 3 (id:??) landed as
https://crrev.com/6a5a246814adb820e6daf1de37215d3047bb3831
Cr-Commit-Position: refs/heads/master@{#319880}

[mnaganov (inactive), 2015-03-10 15:32:02]

On 2015/03/10 14:34:01, boliu wrote:
>
https://codereview.chromium.org/992833002/diff/20001/android_webview/java/src...
> File android_webview/java/src/org/chromium/android_webview/AwContents.java
> (right):
> 
>
https://codereview.chromium.org/992833002/diff/20001/android_webview/java/src...
> android_webview/java/src/org/chromium/android_webview/AwContents.java:2126:
> public void addPossiblyUnsafeJavascriptInterface(Object object, String name) {
> On 2015/03/10 09:53:58, mnaganov (cr) wrote:
> > I think you should rename this method to just 'addJavascriptInterface',
> because
> > 'PossiblyUnsafe' was there due to the fact that you could specify 'null' as
> the
> > annotation, and that would expose all the methods of your Java class, which
is
> > unsafe. And now you can't do that.
> 
> Done.
> 
> And it's more like UnsafeWhenTargetLessThanJBMR1, but whatever :p

Right, but those apps are unsafe anyway, we can't do anything on our side to
help them.