Retry idempotent methods on Chrome-Proxy: bypass

net/http/http_network_transaction.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include <set>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 969 matching lines @@
       }
 
       if (proxy_bypass_event < ProxyService::BYPASS_EVENT_TYPE_MAX) {
         ProxyService* proxy_service = session_->proxy_service();
 
         proxy_service->RecordDataReductionProxyBypassInfo(
             chrome_proxy_used, proxy_info_.proxy_server(), proxy_bypass_event);
 
         if (proxy_service->MarkProxyAsBad(proxy_info_, bypass_duration,
                                           net_log_)) {
-          // Only retry in the case of GETs. We don't want to resubmit a POST
-          // if the proxy took some action.
-          if (request_->method == "GET") {
+          // Only retry idempotent methods.
+          if (request_->method == "GET" ||

[mef, 2013/12/18 16:34:41]

Is request_->method guaranteed to be upper case?

[bengr, 2013/12/18 19:39:47]

Yes. From RFC 2616, sec 5.1.1 Method:

"The Method  token indicates the method to be performed on the resource
identified by the Request-URI. The method is case-sensitive."

+              request_->method == "OPTIONS" ||
+              request_->method == "HEAD" ||
+              request_->method == "PUT" ||
+              request_->method == "DELETE" ||
+              request_->method == "TRACE") {
             ResetConnectionAndRequestForResend();
             return OK;
           }
         }
       }
     }
   }
 #endif
 
   // Like Net.HttpResponseCode, but only for MAIN_FRAME loads.
@@ skipping 538 matching lines @@
       description = base::StringPrintf("Unknown state 0x%08X (%u)", state,
                                        state);
       break;
   }
   return description;
 }
 
 #undef STATE_CASE
 
 }  // namespace net