Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/build/common.gypi

Issue 99283002: Revert 238100 "Don't enable V8 deprecation warnings on Mac just yet" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/build/common.gypi
===================================================================
--- trunk/src/build/common.gypi (revision 238100)
+++ trunk/src/build/common.gypi (working copy)
@@ -2010,8 +2010,7 @@
'ANGLE_DX11',
],
'conditions': [
- # TODO(jochen): Also make this work on Mac.
- ['v8_deprecation_warnings==1 and OS!="mac" and OS!="ios"', {
+ ['v8_deprecation_warnings==1', {
'defines': ['V8_DEPRECATION_WARNINGS',],
}],
['(OS=="mac" or OS=="ios") and asan==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698