Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 992773002: Instrumentation to find jank in DomainReliabilityMonitor::AddBakedInConfigs (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, Deprecated (see juliatuttle)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Instrumentation to find jank in DomainReliabilityMonitor::AddBakedInConfigs BUG=436671 R=mmenke@chromium.org, vadimt@chromium.org, ttuttle@chromium.org, Committed: https://crrev.com/4665b93b9ef94c984144ab1fb8d98757e46439a6 Cr-Commit-Position: refs/heads/master@{#319886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M components/domain_reliability/config.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/domain_reliability/monitor.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-09 22:24:19 UTC) #1
vadimt
lgtm
5 years, 9 months ago (2015-03-09 22:33:41 UTC) #2
mmenke
LGTM, though I think ttuttle's the only owner of this directory.
5 years, 9 months ago (2015-03-09 22:33:47 UTC) #3
Deprecated (see juliatuttle)
lgtm!
5 years, 9 months ago (2015-03-09 22:46:58 UTC) #5
ramant (doing other things)
On 2015/03/09 22:46:58, ttuttle wrote: > lgtm! Thanks mmenke, vadimt and ttuttle
5 years, 9 months ago (2015-03-09 22:47:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992773002/1
5 years, 9 months ago (2015-03-09 22:49:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/42942)
5 years, 9 months ago (2015-03-10 05:27:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992773002/1
5 years, 9 months ago (2015-03-10 14:16:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 15:39:09 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 15:40:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4665b93b9ef94c984144ab1fb8d98757e46439a6
Cr-Commit-Position: refs/heads/master@{#319886}

Powered by Google App Engine
This is Rietveld 408576698