Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 992753002: [Storage] Added tracing for blob creation (Closed)

Created:
5 years, 9 months ago by dmurph
Modified:
5 years, 9 months ago
Reviewers:
michaeln, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Storage] Added tracing for blob creation and reading. BUG=375297 Committed: https://crrev.com/0fb0e948b24e906e844d4c053bab957bacd93a84 Cr-Commit-Position: refs/heads/master@{#320623}

Patch Set 1 #

Patch Set 2 : Added 'Init' trace to register category #

Total comments: 4

Patch Set 3 : Added shared memory tracing #

Total comments: 3

Patch Set 4 : Added more tracing, renamings #

Patch Set 5 : Added more tracing, renamings #

Total comments: 5

Patch Set 6 : Formatting and removing 'this->request_' #

Patch Set 7 : Removed offsets for file operations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
M content/child/webblobregistry_impl.cc View 1 2 3 5 chunks +7 lines, -1 line 0 comments Download
M storage/browser/blob/blob_data_snapshot.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M storage/browser/blob/blob_storage_context.cc View 1 2 3 4 chunks +4 lines, -0 lines 0 comments Download
M storage/browser/blob/blob_url_request_job.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M storage/browser/blob/blob_url_request_job.cc View 1 2 3 4 5 6 9 chunks +24 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (6 generated)
dmurph
Michael, PTAL, this adds tracing to blob creation. Daniel
5 years, 9 months ago (2015-03-09 20:40:17 UTC) #2
michaeln
https://codereview.chromium.org/992753002/diff/20001/content/child/webblobregistry_impl.cc File content/child/webblobregistry_impl.cc (right): https://codereview.chromium.org/992753002/diff/20001/content/child/webblobregistry_impl.cc#newcode37 content/child/webblobregistry_impl.cc:37: TRACE_EVENT0("Storage.Blob", "Init"); this one is probably not so interesting, ...
5 years, 9 months ago (2015-03-09 21:22:03 UTC) #3
dmurph
https://codereview.chromium.org/992753002/diff/20001/content/child/webblobregistry_impl.cc File content/child/webblobregistry_impl.cc (right): https://codereview.chromium.org/992753002/diff/20001/content/child/webblobregistry_impl.cc#newcode37 content/child/webblobregistry_impl.cc:37: TRACE_EVENT0("Storage.Blob", "Init"); On 2015/03/09 21:22:02, michaeln wrote: > this ...
5 years, 9 months ago (2015-03-10 00:39:09 UTC) #4
michaeln
lgtm (modulo reconsider about the label names) https://codereview.chromium.org/992753002/diff/40001/content/child/webblobregistry_impl.cc File content/child/webblobregistry_impl.cc (right): https://codereview.chromium.org/992753002/diff/40001/content/child/webblobregistry_impl.cc#newcode38 content/child/webblobregistry_impl.cc:38: // in ...
5 years, 9 months ago (2015-03-10 21:04:05 UTC) #5
dmurph
Hey Michael, PTAL again, I redid some of the names and I added tracing on ...
5 years, 9 months ago (2015-03-11 22:28:36 UTC) #6
michaeln
https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc File storage/browser/blob/blob_url_request_job.cc (right): https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc#newcode193 storage/browser/blob/blob_url_request_job.cc:193: TRACE_EVENT_ASYNC_END1("Blob", "BlobRequest::CountSize", this->request_, Why use 'this->request_' here and only ...
5 years, 9 months ago (2015-03-11 23:45:08 UTC) #7
dmurph
https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc File storage/browser/blob/blob_url_request_job.cc (right): https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc#newcode193 storage/browser/blob/blob_url_request_job.cc:193: TRACE_EVENT_ASYNC_END1("Blob", "BlobRequest::CountSize", this->request_, On 2015/03/11 at 23:45:08, michaeln wrote: ...
5 years, 9 months ago (2015-03-12 18:16:21 UTC) #8
michaeln
https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc File storage/browser/blob/blob_url_request_job.cc (right): https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc#newcode407 storage/browser/blob/blob_url_request_job.cc:407: int chunk_number = current_file_chunk_number_++; On 2015/03/12 18:16:21, dmurph wrote: ...
5 years, 9 months ago (2015-03-12 20:17:32 UTC) #9
dmurph
On 2015/03/12 at 20:17:32, michaeln wrote: > https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc > File storage/browser/blob/blob_url_request_job.cc (right): > > https://codereview.chromium.org/992753002/diff/80001/storage/browser/blob/blob_url_request_job.cc#newcode407 ...
5 years, 9 months ago (2015-03-12 21:02:14 UTC) #10
michaeln
thnx! lgtm
5 years, 9 months ago (2015-03-12 23:47:09 UTC) #11
dmurph
+jam for webblobregistry_impl.cc
5 years, 9 months ago (2015-03-13 01:12:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992753002/120001
5 years, 9 months ago (2015-03-13 01:12:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/49400)
5 years, 9 months ago (2015-03-13 01:34:59 UTC) #18
jam
lgtm
5 years, 9 months ago (2015-03-13 16:32:14 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992753002/120001
5 years, 9 months ago (2015-03-14 00:17:11 UTC) #21
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 9 months ago (2015-03-14 00:45:25 UTC) #22
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 00:46:14 UTC) #23
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/0fb0e948b24e906e844d4c053bab957bacd93a84
Cr-Commit-Position: refs/heads/master@{#320623}

Powered by Google App Engine
This is Rietveld 408576698