minidump/minidump_module_writer_test.cc - Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_module_writer_test.cc

Issue 992693003: Add ASSERT_DEATH_CHECK() to do ASSERT_DEATH() of CHECK() failures (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_module_writer_test.cc

diff --git a/minidump/minidump_module_writer_test.cc b/minidump/minidump_module_writer_test.cc

index 6024c2ca65bc0238d1009c3d978d4b222507959b..8087e36bf40bf111fb5742622e54265583565342 100644

--- a/minidump/minidump_module_writer_test.cc

+++ b/minidump/minidump_module_writer_test.cc

@@ -33,6 +33,7 @@

#include "util/file/string_file.h"

#include "util/misc/uuid.h"

#include "util/stdlib/pointer_container.h"

+#include "util/test/gtest_death_check.h"

namespace crashpad {

namespace test {

@@ -753,7 +754,8 @@ TEST(MinidumpModuleWriterDeathTest, NoModuleName) {

minidump_file_writer.AddStream(module_list_writer.Pass());

StringFile string_file;

- ASSERT_DEATH(minidump_file_writer.WriteEverything(&string_file), "name_");

+ ASSERT_DEATH_CHECK(minidump_file_writer.WriteEverything(&string_file),

+ "name_");

}

} // namespace

« no previous file with comments | « minidump/minidump_file_writer_test.cc ('k') | minidump/minidump_system_info_writer_test.cc » ('j') | util/test/gtest_death_check.h » ('J')