Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 992683002: Handle *all* runtime versions of intrinsics in the serializer. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
yangguo, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Handle *all* runtime versions of intrinsics in the serializer. Note that this is done only for consistency at this point in time. The change should probably have been in https://codereview.chromium.org/984963002/ already. BUG=v8:3947 LOG=n Committed: https://crrev.com/ea2f15e2a9e0075d48219cd9f21a0399a55e16cf Cr-Commit-Position: refs/heads/master@{#27080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Sven Panne
5 years, 9 months ago (2015-03-09 13:38:35 UTC) #2
Yang
On 2015/03/09 13:38:35, Sven Panne wrote: lgtm.
5 years, 9 months ago (2015-03-09 14:55:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992683002/1
5 years, 9 months ago (2015-03-09 14:55:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 15:11:44 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 15:12:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea2f15e2a9e0075d48219cd9f21a0399a55e16cf
Cr-Commit-Position: refs/heads/master@{#27080}

Powered by Google App Engine
This is Rietveld 408576698