src/factory.cc - Issue 99263002: Remove remaining HandleScope::Close usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 99263002: Remove remaining HandleScope::Close usage (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 01f58544e308c7d22d8e7f37694b1af802ecffcc..483e6a632a3e6f975a9f8bee259869d5e318251a 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -854,7 +854,7 @@ Handle<Object> Factory::NewError(const char* maker,

const char* message,

Vector< Handle<Object> > args) {

// Instantiate a closeable HandleScope for EscapeFrom.

- v8::HandleScope scope(reinterpret_cast<v8::Isolate*>(isolate()));

+ v8::EscapableHandleScope scope(reinterpret_cast<v8::Isolate*>(isolate()));

Handle<FixedArray> array = NewFixedArray(args.length());

for (int i = 0; i < args.length(); i++) {

array->set(i, *args[i]);

« no previous file with comments | « src/debug.cc ('k') | src/handles.h » ('j') | no next file with comments »