Issue 99263002: Remove remaining HandleScope::Close usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 99263002: Remove remaining HandleScope::Close usage (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)

Modified:
7 years ago

Reviewers:
Dmitry Lomov (no reviews), Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove remaining HandleScope::Close usage For some reason, this is only caught when compiling with chromium on Mac. BUG=none R=verwaest@chromium.org, dslomov@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18209

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -32 lines)			Patch
M	src/api.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View	10 chunks	+24 lines, -25 lines	0 comments	Download
M	src/debug.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/handles.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

7 years ago (2013-12-02 18:12:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18209 (presubmit successful).