Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 992623002: Remove the stack size limit from the posix worker pool. (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
Reviewers:
Mark Mentovai, rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the stack size limit from the posix worker pool. We don't use one on windows either, and e.g. for running V8 compile jobs, we need a higher stack size limit than we currently have. Instead of guessing a value, let's just use the default. BUG=464538 R=mark@chromium.org,rmcilroy@chromium.org Committed: https://crrev.com/c704e16994249b75baa904c14dd0c0e62e8e60ef Cr-Commit-Position: refs/heads/master@{#319615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M base/threading/worker_pool_posix.cc View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-09 08:25:11 UTC) #1
rmcilroy
Seems reasonable to me. As I understand it, most OSs don't commit memory for the ...
5 years, 9 months ago (2015-03-09 10:22:04 UTC) #2
jochen (gone - plz use gerrit)
On 2015/03/09 at 10:22:04, rmcilroy wrote: > Seems reasonable to me. As I understand it, ...
5 years, 9 months ago (2015-03-09 10:23:31 UTC) #3
Mark Mentovai
The smaller limit also reduced address space fragmentation, which still might be a problem on ...
5 years, 9 months ago (2015-03-09 13:07:02 UTC) #4
jochen (gone - plz use gerrit)
let's give it a try. if nothing bad turns up after a week, i'll turn ...
5 years, 9 months ago (2015-03-09 13:08:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992623002/1
5 years, 9 months ago (2015-03-09 13:08:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 13:11:20 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:11:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c704e16994249b75baa904c14dd0c0e62e8e60ef
Cr-Commit-Position: refs/heads/master@{#319615}

Powered by Google App Engine
This is Rietveld 408576698