Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2466)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 992593003: [Android WebView] Lay the groundwork for a better onReceivedError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index 9384385d22831811b3e759d02cca213d8acfcb53..6f8fdc7435762144ce9499312b2816947d70b8aa 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -370,14 +370,14 @@ public class AwContents implements SmartClipProvider,
mContentsClient.getCallbackHelper().postOnLoadResource(url);
}
- if (request.isMainFrame && awWebResourceResponse != null
- && awWebResourceResponse.getData() == null) {
+ if (awWebResourceResponse != null && awWebResourceResponse.getData() == null) {
// In this case the intercepted URLRequest job will simulate an empty response
// which doesn't trigger the onReceivedError callback. For WebViewClassic
// compatibility we synthesize that callback. http://crbug.com/180950
mContentsClient.getCallbackHelper().postOnReceivedError(
- ErrorCodeConversionHelper.ERROR_UNKNOWN,
- null /* filled in by the glue layer */, url);
+ request,
+ /* error description filled in by the glue layer */
+ new AwContentsClient.AwWebResourceError());
}
return awWebResourceResponse;
}

Powered by Google App Engine
This is Rietveld 408576698