Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 99253006: Fill the TLS padding extension with zero bytes instead of spaces. (Closed)

Created:
7 years ago by wtc
Modified:
7 years ago
Reviewers:
agl
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Fill the TLS padding extension with zero bytes instead of spaces. R=agl@chromium.org BUG=315828 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/third_party/nss/patches/paddingextension.patch View 1 chunk +1 line, -1 line 0 comments Download
M net/third_party/nss/ssl/ssl3ext.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
wtc
This CL updates our implementation to match draft-agl-tls-padding-02.
7 years ago (2013-12-02 23:07:53 UTC) #1
agl
lgtm
7 years ago (2013-12-02 23:10:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/99253006/1
7 years ago (2013-12-02 23:31:15 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=230969
7 years ago (2013-12-03 05:43:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/99253006/1
7 years ago (2013-12-03 18:51:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/99253006/1
7 years ago (2013-12-03 19:18:53 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-03 21:32:23 UTC) #7
Message was sent while issue was closed.
Change committed as 238460

Powered by Google App Engine
This is Rietveld 408576698