Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 99253005: [Telemetry] Rename PngBitmap->Bitmap and move it to core. (Closed)

Created:
7 years ago by tonyg
Modified:
7 years ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Rename PngBitmap->Bitmap and move it to core. The rename is because I'm planning to generate Bitmaps from things other than PNGs and there's nothing really PNG specific about this Bitmap class. The move is because this is exposed in the Tab API, so it belongs in core, not backends. This will make the new Platform video capture API a little cleaner too. BUG=323813 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238351

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -297 lines) Patch
M content/test/gpu/gpu_tests/maps.py View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
D tools/telemetry/telemetry/core/backends/png_bitmap.py View 1 chunk +0 lines, -168 lines 0 comments Download
D tools/telemetry/telemetry/core/backends/png_bitmap_unittest.py View 1 chunk +0 lines, -82 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/webdriver/webdriver_tab_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/telemetry/telemetry/core/bitmap.py View 6 chunks +37 lines, -36 lines 0 comments Download
A tools/telemetry/telemetry/core/bitmap_unittest.py View 1 chunk +82 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/__init__.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/tab.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tonyg
7 years ago (2013-12-02 22:54:01 UTC) #1
dtu
lgtm
7 years ago (2013-12-02 23:53:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/99253005/1
7 years ago (2013-12-02 23:59:38 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=38990
7 years ago (2013-12-03 00:18:06 UTC) #4
tonyg
kbr, zmo, Could one of you please provide content/test/gpu/OWNERS
7 years ago (2013-12-03 00:20:39 UTC) #5
Zhenyao Mo
On 2013/12/03 00:20:39, tonyg wrote: > kbr, zmo, Could one of you please provide content/test/gpu/OWNERS ...
7 years ago (2013-12-03 00:25:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/99253005/1
7 years ago (2013-12-03 01:03:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/99253005/20001
7 years ago (2013-12-03 02:43:38 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests, content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195815
7 years ago (2013-12-03 04:18:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/99253005/20001
7 years ago (2013-12-03 04:19:10 UTC) #10
commit-bot: I haz the power
7 years ago (2013-12-03 11:31:24 UTC) #11
Message was sent while issue was closed. 
Change committed as 238351

Powered by Google App Engine
This is Rietveld 408576698