Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 99253004: cc: Allow copy requests to provide a texture. (Closed)

Created:
7 years ago by danakj
Modified:
7 years ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org, hubbe, Wez
Visibility:
Public.

Description

cc: Allow copy requests to provide a texture. When many readbacks will be occuring in a row, we don't want to have texture create/delete calls constantly churning through GPU memory. In particular, this has been a severe performance bottleneck on some intel drivers. Instead provide a way for the copy request client to provide a texture to the compositor that it will use, and then the texture can be reused for as long as the client wishes. In the case of tab capture, the client (in RenderWidgetHostViewAura) wants to use the GLHelper to act on the given texture. Since the GLHelper lives on the main thread, and the compositor draws on the compositor thread, we provide the texture from the client through the main thread CopyOutputRequest API rather than hooking directly into the compositor thread. I moved the async readback unit tests out to their own file as there are now quite a few. Tests: LayerTreeHostCopyRequestTestCreatesTexture LayerTreeHostCopyRequestTestProvideTexture R=piman@chromium.org BUG=312497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238324

Patch Set 1 : mailbox: #

Patch Set 2 : mailbox: #

Unified diffs Side-by-side diffs Delta from patch set Stats (+935 lines, -689 lines) Patch
M cc/cc_tests.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/copy_output_request.h View 1 5 chunks +13 lines, -10 lines 0 comments Download
M cc/output/copy_output_request.cc View 1 3 chunks +23 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +48 lines, -22 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.h View 2 chunks +7 lines, -0 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -654 lines 0 comments Download
A cc/trees/layer_tree_host_unittest_copyrequest.cc View 1 chunk +831 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
Hubbe has confirmed that this, along with the followup in RWHVA does fix the intel ...
7 years ago (2013-12-02 20:16:00 UTC) #1
piman
lgtm
7 years ago (2013-12-03 01:21:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/99253004/100001
7 years ago (2013-12-03 05:52:57 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-03 08:04:33 UTC) #4
Message was sent while issue was closed.
Change committed as 238324

Powered by Google App Engine
This is Rietveld 408576698