Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3367)

Unified Diff: build/common.gypi

Issue 99253002: Don't enable V8 deprecation warnings on Mac just yet (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index c56e910ef6e4a23864a43c627be903a939daac6e..34c4eb3b0d87e3a8aec95716dfc30655fee12cc6 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2010,7 +2010,8 @@
'ANGLE_DX11',
],
'conditions': [
- ['v8_deprecation_warnings==1', {
+ # TODO(jochen): Also make this work on Mac.
+ ['v8_deprecation_warnings==1 and OS!="mac" and OS!="ios"', {
'defines': ['V8_DEPRECATION_WARNINGS',],
}],
['(OS=="mac" or OS=="ios") and asan==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698