lib/Transforms/NaCl/PNaClABISimplify.cpp - Issue 992493002: Lower signatures exposing struct registers to byval struct pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/Transforms/NaCl/PNaClABISimplify.cpp

Issue 992493002: Lower signatures exposing struct registers to byval struct pointers (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Patch Set: First draft Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« lib/Transforms/NaCl/NormalizeStructRegSignatures.cpp ('K') | « lib/Transforms/NaCl/NormalizeStructRegSignatures.cpp ('k') | test/Transforms/NaCl/normalize-struct-reg-signatures.ll » ('j') | test/Transforms/NaCl/normalize-struct-reg-signatures.ll » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/Transforms/NaCl/PNaClABISimplify.cpp

diff --git a/lib/Transforms/NaCl/PNaClABISimplify.cpp b/lib/Transforms/NaCl/PNaClABISimplify.cpp

index 99e3796abeee99a39341afedddf6ec7660e41bb4..073f2d1068559b2c8831b8a1d63118c09db44b01 100644

--- a/lib/Transforms/NaCl/PNaClABISimplify.cpp

+++ b/lib/Transforms/NaCl/PNaClABISimplify.cpp

@@ -151,6 +151,9 @@ void llvm::PNaClABISimplifyAddPostOptPasses(PassManagerBase &PM) {

// ConstantExprs have already been expanded out.

PM.add(createReplacePtrsWithIntsPass());

+ // Convert struct reg function params to struct* byval

+ PM.add(createNormalizeStructRegSignaturesPass());

// The atomic cmpxchg instruction returns a struct, and is rewritten to an

// intrinsic as a post-opt pass, we therefore need to expand struct regs one

// last time.