Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 992463002: gpu: Convert egl_main_native target to GN build. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, no sievers
CC:
chromium-reviews, piman+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Convert egl_main_native target to GN build. Tested with the following command lines on Linux: $ gn gen out-gn $ ninja -C out-gn native $ ninja -C out-gn gpu/gles2_conform_support/native $ gn check out-gn //gpu/gles2_conform_support/native/* BUG=432959 TEST=see above R=dpranke@chromium.org,sievers@chromium.org Committed: https://crrev.com/898dab8c8dfbb95ef4b43353d6973950e0503711 Cr-Commit-Position: refs/heads/master@{#319765}

Patch Set 1 #

Total comments: 6

Patch Set 2 : win fix #

Total comments: 1

Patch Set 3 : put main back #

Patch Set 4 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A gpu/gles2_conform_support/native/BUILD.gn View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
tfarina
PTAL! https://codereview.chromium.org/992463002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/992463002/diff/1/BUILD.gn#newcode58 BUILD.gn:58: "//gpu/gles2_conform_support/native", I just added this line here to ...
5 years, 9 months ago (2015-03-08 15:07:32 UTC) #1
Dirk Pranke
lgtm w/ either putting main.cc back into the target or getting approval from piman@ or ...
5 years, 9 months ago (2015-03-08 21:02:29 UTC) #3
tfarina
https://codereview.chromium.org/992463002/diff/1/gpu/gles2_conform_support/gles2_conform_support.gyp File gpu/gles2_conform_support/gles2_conform_support.gyp (right): https://codereview.chromium.org/992463002/diff/1/gpu/gles2_conform_support/gles2_conform_support.gyp#newcode12 gpu/gles2_conform_support/gles2_conform_support.gyp:12: 'native/main.cc', On 2015/03/08 21:02:29, Dirk Pranke wrote: > On ...
5 years, 9 months ago (2015-03-09 21:53:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992463002/60001
5 years, 9 months ago (2015-03-09 21:54:33 UTC) #7
Dirk Pranke
still lgtm, thanks!
5 years, 9 months ago (2015-03-09 22:36:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48409)
5 years, 9 months ago (2015-03-09 22:59:54 UTC) #10
tfarina
Daniel, could you approve this? Thanks!
5 years, 9 months ago (2015-03-09 23:01:56 UTC) #12
no sievers
lgtm
5 years, 9 months ago (2015-03-09 23:06:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992463002/60001
5 years, 9 months ago (2015-03-09 23:13:29 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-09 23:26:35 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:27:17 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/898dab8c8dfbb95ef4b43353d6973950e0503711
Cr-Commit-Position: refs/heads/master@{#319765}

Powered by Google App Engine
This is Rietveld 408576698