Issue 992403002: Simplify and fix sorting of PatchFiles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 992403002: Simplify and fix sorting of PatchFiles. (Closed)

Created:
5 years, 9 months ago by esprehn

Modified:
5 years, 9 months ago

Reviewers:
jrobbins, ojan

CC:
chromium-reviews, rmistry+cc_chromium.org

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

Simplify and fix sorting of PatchFiles. The prefix of a PatchFile must be initialized to the name value if there's no extension, otherwise files without extensions sort randomly because the sort is not stable and we treat them all the same by sorting on the empty extension. I also simplified down the sorting logic and made the acceptable header extensions match Rietveld's python. Fixes https://github.com/esprehn/chromium-codereview/issues/121 R=ojan@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/c1ea9879e6642a5a248faf2521dbdeb5eff46bd5

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -32 lines)			Patch
	M	appengine/chromium_rietveld/new_static/model/patch_file.js	View		3 chunks	+14 lines, -12 lines	0 comments	Download
	M	appengine/chromium_rietveld/new_static/model/tests/patch_set_tests.js	View		1 chunk	+66 lines, -20 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/992403002/1

5 years, 9 months ago (2015-03-10 23:57:53 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-11 00:20:39 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/c1ea9879e6642a5a248faf2521dbd...