Decouple Cache Storage messaging from Service Worker/Embedded Worker

content/browser/service_worker/cache_storage_dispatcher_host.cc

Index: content/browser/service_worker/cache_storage_dispatcher_host.cc
diff --git a/content/browser/service_worker/cache_storage_dispatcher_host.cc b/content/browser/service_worker/cache_storage_dispatcher_host.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d65e5b0c56b37419e4eabd2d3a61148bbeb275e0
--- /dev/null
+++ b/content/browser/service_worker/cache_storage_dispatcher_host.cc
@@ -0,0 +1,56 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/service_worker/cache_storage_dispatcher_host.h"
+
+#include "base/logging.h"
+#include "content/browser/service_worker/cache_storage_context_impl.h"
+#include "content/browser/service_worker/service_worker_cache_listener.h"
+#include "content/common/service_worker/cache_storage_messages.h"
+#include "content/public/browser/content_browser_client.h"
+
+namespace content {
+
+namespace {
+
+const uint32 kFilteredMessageClasses[] = {CacheStorageMsgStart};
+
+}  // namespace
+
+CacheStorageDispatcherHost::CacheStorageDispatcherHost()
+    : BrowserMessageFilter(kFilteredMessageClasses,
+                           arraysize(kFilteredMessageClasses)) {
+}
+
+CacheStorageDispatcherHost::~CacheStorageDispatcherHost() {
+}
+
+void CacheStorageDispatcherHost::Init(CacheStorageContextImpl* context) {
+  DCHECK_CURRENTLY_ON(BrowserThread::UI);
+  BrowserThread::PostTask(
+      BrowserThread::IO, FROM_HERE,
+      base::Bind(&CacheStorageDispatcherHost::CreateCacheListener, this,
+                 make_scoped_refptr(context)));
+}
+
+void CacheStorageDispatcherHost::OnDestruct() const {
+  BrowserThread::DeleteOnIOThread::Destruct(this);
+}
+
+bool CacheStorageDispatcherHost::OnMessageReceived(
+    const IPC::Message& message) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);

[jkarlin, 2015/03/17 19:55:29]

DCHECK(cache_listener_) so that we know that Init was called?

[jsbell, 2015/03/17 21:38:13]

Will do!

[jsbell, 2015/03/18 00:00:10]

Actually... don't we frown on DCHECK(ptr); ptr->Method(...); since the crash
will be just as informative? Or maybe that was just WebKit. Anyway, adding it.

+  bool handled = cache_listener_->OnMessageReceived(message);
+  if (!handled)
+    BadMessageReceived();
+  return handled;
+}
+
+void CacheStorageDispatcherHost::CreateCacheListener(
+    CacheStorageContextImpl* context) {
+  DCHECK_CURRENTLY_ON(BrowserThread::IO);
+  cache_listener_.reset(new ServiceWorkerCacheListener(this, context));
+}
+
+}  // namespace content