Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 992303002: handler/mac: Respect the uploads-enabled user preference and rate-limit upload attempts (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

handler/mac: Respect the uploads-enabled user preference and rate-limit upload attempts to no more than 1 per hour. The rate limiting is simplistic but duplicates the existing Breakpad client’s behavior, and is suitable for the time being. TEST=run_with_crashpad --handler crashpad_handler \ -a --database=/tmp/crashpad_db \ -a --url=https://clients2.google.com/cr/staging_report \ -a --annotation=prod=crashpad \ -a --annotation=ver=0.7.0 \ crashy_program R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/42db629ee334fa8cd63f085e4adaab5f4fe938eb

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M handler/mac/crash_report_upload_thread.cc View 3 chunks +44 lines, -2 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
The pieces keep getting smaller and smaller…
5 years, 9 months ago (2015-03-10 19:00:18 UTC) #2
Robert Sesek
https://codereview.chromium.org/992303002/diff/1/handler/mac/crash_report_upload_thread.cc File handler/mac/crash_report_upload_thread.cc (right): https://codereview.chromium.org/992303002/diff/1/handler/mac/crash_report_upload_thread.cc#newcode245 handler/mac/crash_report_upload_thread.cc:245: // it “happened” at least one day in the ...
5 years, 9 months ago (2015-03-10 19:20:54 UTC) #3
Mark Mentovai
https://codereview.chromium.org/992303002/diff/1/handler/mac/crash_report_upload_thread.cc File handler/mac/crash_report_upload_thread.cc (right): https://codereview.chromium.org/992303002/diff/1/handler/mac/crash_report_upload_thread.cc#newcode245 handler/mac/crash_report_upload_thread.cc:245: // it “happened” at least one day in the ...
5 years, 9 months ago (2015-03-10 19:28:24 UTC) #4
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-10 19:30:21 UTC) #5
Mark Mentovai
5 years, 9 months ago (2015-03-10 19:31:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
42db629ee334fa8cd63f085e4adaab5f4fe938eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698