Issue 992273002: Random drive-by cleanup.

Issue 992273002: Random drive-by cleanup. (Closed)

Created:
5 years, 9 months ago by viettrungluu

Modified:
5 years, 9 months ago

Reviewers:
hansmuller, hansmuller1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Random drive-by cleanup. R=hansmuller@google.com, hansmuller@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/33afb156c28fcff3527b806f3574e90f54cf4990

Patch Set 2 : log seek failures #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -23 lines)			Patch
M	mojo/common/data_pipe_utils.cc	View	1	4 chunks	+8 lines, -9 lines	0 comments	Download
M	shell/application_manager/data_pipe_peek.cc	View		5 chunks	+14 lines, -10 lines	0 comments	Download
M	shell/shell_apptest.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hansmuller1

LGTM https://codereview.chromium.org/992273002/diff/1/mojo/common/data_pipe_utils.cc File mojo/common/data_pipe_utils.cc (right): https://codereview.chromium.org/992273002/diff/1/mojo/common/data_pipe_utils.cc#newcode79 mojo/common/data_pipe_utils.cc:79: if (file.Seek(base::File::FROM_BEGIN, skip) != skip) Maybe we should ...

5 years, 9 months ago (2015-03-11 22:02:01 UTC) #4

viettrungluu

Thanks. https://codereview.chromium.org/992273002/diff/1/mojo/common/data_pipe_utils.cc File mojo/common/data_pipe_utils.cc (right): https://codereview.chromium.org/992273002/diff/1/mojo/common/data_pipe_utils.cc#newcode79 mojo/common/data_pipe_utils.cc:79: if (file.Seek(base::File::FROM_BEGIN, skip) != skip) On 2015/03/11 22:02:01, ...

5 years, 9 months ago (2015-03-11 23:58:23 UTC) #5

viettrungluu

5 years, 9 months ago (2015-03-11 23:58:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
33afb156c28fcff3527b806f3574e90f54cf4990 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages